Date: Sun, 5 Jul 2015 03:18:17 +0000 From: "araujo (Marcelo Araujo)" <phabric-noreply@FreeBSD.org> To: freebsd-toolchain@freebsd.org Subject: [Differential] [Updated, 55 lines] D2690: In ypbind, eliminate error: dereferencing type-punned pointer will break strict-aliasing rules Message-ID: <5f07774b76b6035b3e14869abb5528ad@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-5wjobtbl22co3qb2erjl-req@FreeBSD.org> References: <differential-rev-PHID-DREV-5wjobtbl22co3qb2erjl-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--b1_5f07774b76b6035b3e14869abb5528ad Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: 8bit araujo updated this revision to Diff 6699. araujo added a comment. Update @rodrigc's patch with dim's review and with my changes too. I'm gonna start to test it today! REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D2690?vs=5826&id=6699 BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D2690 AFFECTED FILES usr.sbin/ypbind/ypbind.c EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: araujo, bapt, emaste, dim, rodrigc Cc: imp, freebsd-toolchain-list --b1_5f07774b76b6035b3e14869abb5528ad Content-Type: text/x-patch; charset=utf-8; name="D2690.6699.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D2690.6699.patch" ZGlmZiAtLWdpdCBhL3Vzci5zYmluL3lwYmluZC95cGJpbmQuYyBiL3Vzci5zYmluL3lwYmluZC95 cGJpbmQuYwotLS0gYS91c3Iuc2Jpbi95cGJpbmQveXBiaW5kLmMKKysrIGIvdXNyLnNiaW4veXBi aW5kL3lwYmluZC5jCkBAIC0xMDYsMTYgKzEwNiwxNiBAQAogdm9pZAl5cF9yZXN0cmljdGVkX21v ZGUoY2hhciAqKTsKIGludAl2ZXJpZnkoc3RydWN0IGluX2FkZHIpOwogCi1jaGFyICpkb21haW5f bmFtZTsKLXN0cnVjdCBfZG9tX2JpbmRpbmcgKnlwYmluZGxpc3Q7CitzdGF0aWMgY2hhciAqZG9t YWluX25hbWU7CitzdGF0aWMgc3RydWN0IF9kb21fYmluZGluZyAqeXBiaW5kbGlzdDsKIHN0YXRp YyBzdHJ1Y3QgX2RvbV9iaW5kaW5nICpicm9hZF9kb21haW47CiAKICNkZWZpbmUgWVBTRVRfTk8J MAogI2RlZmluZSBZUFNFVF9MT0NBTAkxCiAjZGVmaW5lIFlQU0VUX0FMTAkyCi1pbnQgeXBzZXRt b2RlID0gWVBTRVRfTk87Ci1pbnQgeXBzZWN1cmVtb2RlID0gMDsKLWludCBwcGlkOworc3RhdGlj IGludCB5cHNldG1vZGUgPSBZUFNFVF9OTzsKK3N0YXRpYyBpbnQgeXBzZWN1cmVtb2RlID0gMDsK K3N0YXRpYyBpbnQgcHBpZDsKIAogI2RlZmluZSBOT1RfUkVTUE9ORElOR19IWVNURVJFU0lTIDEw CiBzdGF0aWMgaW50IG5vdF9yZXNwb25kaW5nX2NvdW50ID0gMDsKQEAgLTEyNiw5ICsxMjYsOSBA QAogICogaW4gcmVzdHJpY3RlZF9hZGRycyB3aWxsIGJlIHVzZWQgZm9yIGJpbmRpbmcuCiAgKi8K ICNkZWZpbmUgUkVTVFJJQ1RFRF9TRVJWRVJTIDEwCi1pbnQgeXBfcmVzdHJpY3RlZCA9IDA7Ci1p bnQgeXBfbWFueWNhc3QgPSAwOwotc3RydWN0IGluX2FkZHIgcmVzdHJpY3RlZF9hZGRyc1tSRVNU UklDVEVEX1NFUlZFUlNdOworc3RhdGljIGludCB5cF9yZXN0cmljdGVkID0gMDsKK3N0YXRpYyBp bnQgeXBfbWFueWNhc3QgPSAwOworc3RhdGljIHN0cnVjdCBpbl9hZGRyIHJlc3RyaWN0ZWRfYWRk cnNbUkVTVFJJQ1RFRF9TRVJWRVJTXTsKIAogLyogTm8gbW9yZSB0aGFuIE1BWF9DSElMRFJFTiBj aGlsZCBicm9hZGNhc3RlcnMgYXQgYSB0aW1lLiAqLwogI2lmbmRlZiBNQVhfQ0hJTERSRU4KQEAg LTE0OCwxMyArMTQ4LDEzIEBACiAjZGVmaW5lIE1BWF9SRVRSSUVTIDMwCiAjZW5kaWYKIAotaW50 IHJldHJpZXMgPSAwOwotaW50IGNoaWxkcmVuID0gMDsKLWludCBkb21haW5zID0gMDsKLWludCB5 cGxvY2tmZDsKLWZkX3NldCBmZHNyOworc3RhdGljIGludCByZXRyaWVzID0gMDsKK3N0YXRpYyBp bnQgY2hpbGRyZW4gPSAwOworc3RhdGljIGludCBkb21haW5zID0gMDsKK3N0YXRpYyBpbnQgeXBs b2NrZmQ7CitzdGF0aWMgZmRfc2V0IGZkc3I7CiAKLVNWQ1hQUlQgKnVkcHRyYW5zcCwgKnRjcHRy YW5zcDsKK3N0YXRpYyBTVkNYUFJUICp1ZHB0cmFuc3AsICp0Y3B0cmFuc3A7CiAKIHZvaWQgKgog eXBiaW5kcHJvY19udWxsXzJfeXAoU1ZDWFBSVCAqdHJhbnNwLCB2b2lkICphcmdwLCBDTElFTlQg KmNsbnQpCkBAIC0xNjUsNyArMTY1LDcgQEAKIAlyZXR1cm4gJnJlczsKIH0KIAotc3RydWN0IHlw YmluZF9yZXNwICoKK3N0YXRpYyBzdHJ1Y3QgeXBiaW5kX3Jlc3AgKgogeXBiaW5kcHJvY19kb21h aW5fMl95cChTVkNYUFJUICp0cmFuc3AsIGRvbWFpbm5hbWUgKmFyZ3AsIENMSUVOVCAqY2xudCkK IHsKIAlzdGF0aWMgc3RydWN0IHlwYmluZF9yZXNwIHJlczsKQEAgLTIyNSwxMCArMjI1LDEwIEBA CiAKIAlyZXMueXBiaW5kX3N0YXR1cyA9IFlQQklORF9TVUNDX1ZBTDsKIAlyZXMueXBiaW5kX3Jl c3BfdS55cGJpbmRfZXJyb3IgPSAwOyAvKiBTdWNjZXNzICovCi0JKih1X2ludDMyX3QgKikmcmVz LnlwYmluZF9yZXNwX3UueXBiaW5kX2JpbmRpbmZvLnlwYmluZF9iaW5kaW5nX2FkZHIgPQotCQl5 cGRiLT5kb21fc2VydmVyX2FkZHIuc2luX2FkZHIuc19hZGRyOwotCSoodV9zaG9ydCAqKSZyZXMu eXBiaW5kX3Jlc3BfdS55cGJpbmRfYmluZGluZm8ueXBiaW5kX2JpbmRpbmdfcG9ydCA9Ci0JCXlw ZGItPmRvbV9zZXJ2ZXJfYWRkci5zaW5fcG9ydDsKKwltZW1jcHkoJnJlcy55cGJpbmRfcmVzcF91 LnlwYmluZF9iaW5kaW5mby55cGJpbmRfYmluZGluZ19hZGRyLAorCSAgICAmeXBkYi0+ZG9tX3Nl cnZlcl9hZGRyLnNpbl9hZGRyLnNfYWRkciwgc2l6ZW9mKHVfaW50MzJfdCkpOworCW1lbWNweSgm cmVzLnlwYmluZF9yZXNwX3UueXBiaW5kX2JpbmRpbmZvLnlwYmluZF9iaW5kaW5nX3BvcnQsCisJ ICAgICZ5cGRiLT5kb21fc2VydmVyX2FkZHIuc2luX3BvcnQsIHNpemVvZih1X3Nob3J0KSk7CiAJ LypwcmludGYoImRvbWFpbiAlcyBhdCAlcy8lZFxuIiwgeXBkYi0+ZG9tX2RvbWFpbiwKIAkJaW5l dF9udG9hKHlwZGItPmRvbV9zZXJ2ZXJfYWRkci5zaW5fYWRkciksCiAJCW50b2hzKHlwZGItPmRv bV9zZXJ2ZXJfYWRkci5zaW5fcG9ydCkpOyovCkBAIC0yNzUsOCArMjc1LDEyIEBACiAKIAliemVy bygmYmluZHNpbiwgc2l6ZW9mIGJpbmRzaW4pOwogCWJpbmRzaW4uc2luX2ZhbWlseSA9IEFGX0lO RVQ7Ci0JYmluZHNpbi5zaW5fYWRkci5zX2FkZHIgPSAqKHVfaW50MzJfdCAqKWFyZ3AtPnlwc2V0 ZG9tX2JpbmRpbmcueXBiaW5kX2JpbmRpbmdfYWRkcjsKLQliaW5kc2luLnNpbl9wb3J0ID0gKih1 X3Nob3J0ICopYXJncC0+eXBzZXRkb21fYmluZGluZy55cGJpbmRfYmluZGluZ19wb3J0OworCW1l bWNweSgmYmluZHNpbi5zaW5fYWRkci5zX2FkZHIsCisJICAgICZhcmdwLT55cHNldGRvbV9iaW5k aW5nLnlwYmluZF9iaW5kaW5nX2FkZHIsCisJICAgIHNpemVvZih1X2ludDMyX3QpKTsKKwltZW1j cHkoJmJpbmRzaW4uc2luX3BvcnQsCisJICAgICZhcmdwLT55cHNldGRvbV9iaW5kaW5nLnlwYmlu ZF9iaW5kaW5nX3BvcnQsCisJICAgIHNpemVvZih1X3Nob3J0KSk7CiAJcnBjX3JlY2VpdmVkKGFy Z3AtPnlwc2V0ZG9tX2RvbWFpbiwgJmJpbmRzaW4sIDEpOwogCiAJcmV0dXJuKCh2b2lkICopICZy ZXN1bHQpOwpAQCAtNjE1LDggKzYxOSw3IEBACiAJcmV0dXJuICgwKTsKIH0KIAotYm9vbF90IGJy b2FkY2FzdF9yZXN1bHQob3V0LCBhZGRyKQotYm9vbF90ICpvdXQ7CitzdGF0aWMgYm9vbF90IGJy b2FkY2FzdF9yZXN1bHQob3V0LCBhZGRyKQogc3RydWN0IHNvY2thZGRyX2luICphZGRyOwogewog CWlmIChyZXRyaWVzID49IE1BWF9SRVRSSUVTKSB7CkBAIC05NDUsOCArOTQ4LDEwIEBACiAKIAli emVybygmeWJyLCBzaXplb2YgeWJyKTsKIAl5YnIueXBiaW5kX3N0YXR1cyA9IFlQQklORF9TVUND X1ZBTDsKLQkqKHVfaW50MzJfdCAqKSZ5YnIueXBiaW5kX3Jlc3BfdS55cGJpbmRfYmluZGluZm8u eXBiaW5kX2JpbmRpbmdfYWRkciA9IHJhZGRycC0+c2luX2FkZHIuc19hZGRyOwotCSoodV9zaG9y dCAqKSZ5YnIueXBiaW5kX3Jlc3BfdS55cGJpbmRfYmluZGluZm8ueXBiaW5kX2JpbmRpbmdfcG9y dCA9IHJhZGRycC0+c2luX3BvcnQ7CisJbWVtY3B5KCZ5YnIueXBiaW5kX3Jlc3BfdS55cGJpbmRf YmluZGluZm8ueXBiaW5kX2JpbmRpbmdfYWRkciwKKwkgICAgJnJhZGRycC0+c2luX2FkZHIuc19h ZGRyLCBzaXplb2YodV9pbnQzMl90KSk7CisJbWVtY3B5KCZ5YnIueXBiaW5kX3Jlc3BfdS55cGJp bmRfYmluZGluZm8ueXBiaW5kX2JpbmRpbmdfcG9ydCwKKwkgICAgJnJhZGRycC0+c2luX3BvcnQs IHNpemVvZih1X3Nob3J0KSk7CiAKIAlpZiAod3JpdGV2KHlwZGItPmRvbV9sb2NrZmQsIGlvdiwg MikgIT0gaW92WzBdLmlvdl9sZW4gKyBpb3ZbMV0uaW92X2xlbikgewogCQlzeXNsb2coTE9HX1dB Uk5JTkcsICJ3cml0ZTogJW0iKTsKCg== --b1_5f07774b76b6035b3e14869abb5528ad--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5f07774b76b6035b3e14869abb5528ad>