Date: Sat, 21 Sep 2002 14:16:09 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: "David O'Brien" <obrien@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Kris Kennaway <kris@FreeBSD.org>, Bruce Evans <bde@FreeBSD.org> Subject: Re: cvs commit: src/secure/lib/libcrypto Makefile.inc src/secure/lib/libssl Makefile Message-ID: <20020921111609.GC98578@sunbay.com> In-Reply-To: <20020921075416.E7923-100000@gamplex.bde.org> References: <20020920165147.GA58348@dragon.nuxi.com> <20020921075416.E7923-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--OBd5C1Lgu00Gd/Tn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Sep 21, 2002 at 08:04:52AM +1000, Bruce Evans wrote:
> On Fri, 20 Sep 2002, David O'Brien wrote:
>=20
> > On Fri, Sep 20, 2002 at 06:59:10PM +0300, Ruslan Ermilov wrote:
> > > My proposed "real fix" is to unobfuscate these makefiles by not
> > > using the ${.OBJDIR}/openssl, at the cost of losing the ability
> > > to build these libraries in the standalone mode (outside of the
> > > buildworld and if new headers do not match /usr/include/openssl
> > > stuff).
> >
> > Not acceptable. Just about everything else can be build outside a world
> > build (when the headers don't agree).
> >=20
Um, and how does one build secure/usr.bin/openssl standalone when
headers change?
> > Time and time again on 5-CURRENT
> > the only why to get over a bump (if you haven't make world daily), is to
> > manually build parts of the tree.
> >=20
This is news to me, I'll re-check again if 4.0-RELEASE can be
bootstrapped to a fresh 5.0-CURRENT.
> You can still do this by installing the necessary headers.
>=20
Yep, as the (omitted) part of my original email already explained.
> A version of "make installincludes" that doesn't spam /usr/include might
> be useful.
>=20
Where this version would install their headers? ${.OBJDIR}/openssl?
How then we would track the headers dependencies?
> > What in the world did you change and why did you feel the need to make
> > the change?? Things were working fine. Is this what broke things?
> >
> > ru 2002/09/19 06:24:28 PDT
> > Modified files:
> > secure/lib/libcrypto Makefile.inc
> > Log:
> > Added the missing dependencies for openssl/ headers.
> > Revision Changes Path
> > 1.26 +7 -5 src/secure/lib/libcrypto/Makefile.inc
>=20
> Things weren't working fine, except in the world case.
>=20
Even in the world case (NOCLEAN) things were broken: things blew
up when I attempted to upgrade the 4.6-RELEASE box to 4.6-STABLE
which advanced CRYPTO_NUM_LOCKS from 28 to 29 in crypto.h, and
that caused the "Inconsistency between crypto.h and cryptlib.c"
in cryptlib.c. But I think David was pretty aware of this:
1.11 (obrien 15-May-00): # XXX: The openssl/ dependencies are no=
t correct, in that a change in
1.11 (obrien 15-May-00): # any of ${CRYPTO_HDRS} ${EXTRA_HDRS} wi=
ll no repopulate openssl/.
1.11 (obrien 15-May-00): # This deficiency will be fixed in a lat=
er commit.
> The (rather large) dependencies for the generated headers were mostly
>=20
Most headers aren't even generated, they are just collected all over
and copied into a single place.
> missing, so
> non-world builds used to break regularly when the headers in src/crypto
> changed, unless you know about the problem and "fixed" it using "make
> cleandir" or otherwise (it suffices to delete a couple of generated
> headers; then all of the generated headers will be regenerated).
>=20
Yep, there was a (rather strange) binding to opensslconf.h.
Cheers,
--=20
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
--OBd5C1Lgu00Gd/Tn
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)
iD8DBQE9jFT5Ukv4P6juNwoRAsWYAJ9MFBOqiBoj74F6HBWlU5hjy1pVywCfRwmS
rtJHa/j0xF+Wy4QawCOIpco=
=mb9w
-----END PGP SIGNATURE-----
--OBd5C1Lgu00Gd/Tn--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020921111609.GC98578>