Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 27 Nov 2012 11:59:05 +0200
From:      Andriy Gapon <avg@FreeBSD.org>
To:        David Xu <davidxu@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Konstantin Belousov <kib@FreeBSD.org>
Subject:   Re: svn commit: r243599 - head/sys/kern
Message-ID:  <50B48EE9.1090506@FreeBSD.org>
In-Reply-To: <201211270607.qAR67w6O094153@svn.freebsd.org>
References:  <201211270607.qAR67w6O094153@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
on 27/11/2012 08:07 David Xu said the following:
> Author: davidxu
> Date: Tue Nov 27 06:07:58 2012
> New Revision: 243599
> URL: http://svnweb.freebsd.org/changeset/base/243599
> 
> Log:
>   Take first active vnode correctly.
>   
>   Reviewed by:	kib
>   MFC after:	3 days
> 
> Modified:
>   head/sys/kern/vfs_subr.c
> 
> Modified: head/sys/kern/vfs_subr.c
> ==============================================================================
> --- head/sys/kern/vfs_subr.c	Tue Nov 27 06:01:02 2012	(r243598)
> +++ head/sys/kern/vfs_subr.c	Tue Nov 27 06:07:58 2012	(r243599)
> @@ -4755,7 +4755,7 @@ __mnt_vnode_first_active(struct vnode **
>  	MNT_REF(mp);
>  	(*mvp)->v_type = VMARKER;
>  
> -	vp = TAILQ_NEXT(*mvp, v_actfreelist);
> +	vp = TAILQ_FIRST(&mp->mnt_activevnodelist);
>  	while (vp != NULL) {
>  		VI_LOCK(vp);
>  		if (vp->v_mount == mp && vp->v_type != VMARKER &&
> 

Oh, wow, did this even work before?
Did it always just return NULL and no active list iteration happened?

-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50B48EE9.1090506>