Date: Sat, 16 Jun 2018 11:53:49 -0700 From: Conrad Meyer <cem@freebsd.org> To: Kurt Lidl <lidl@pix.net> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334947 - head/sys/modules Message-ID: <CAG6CVpX4hD8dPMQwOpNgBKH0hxAkdeRkVf=1f_PkeBPF64Gx1g@mail.gmail.com> In-Reply-To: <b87a18ea-8580-7c46-ade0-9beee7528b55@pix.net> References: <201806110842.w5B8g4we013345@repo.freebsd.org> <b87a18ea-8580-7c46-ade0-9beee7528b55@pix.net>
next in thread | previous in thread | raw e-mail | index | archive | help
r255185 added _mm_aesenc(), etc, but not _mm_sha*(). That's probably where the report comes from. (If you feel it is worth your while adding sha intrinsics to a decade-old GCC, go ahead, but I think gcc 4.2 on x86 is pretty dead.) Best, Conrad On Sat, Jun 16, 2018 at 7:57 AM, Kurt Lidl <lidl@pix.net> wrote: > On 6/11/18 4:42 AM, Dimitry Andric wrote: >> >> Author: dim >> Date: Mon Jun 11 08:42:03 2018 >> New Revision: 334947 >> URL: https://svnweb.freebsd.org/changeset/base/334947 >> >> Log: >> Disable building aesni with base gcc >> Because base gcc does not support the required intrinsics, do not >> attempt to compile the aesni module with it. >> Noticed by: Dan Allen <danallen46@gmail.com> >> MFC after: 3 days >> >> Modified: >> head/sys/modules/Makefile >> >> Modified: head/sys/modules/Makefile >> >> ============================================================================== >> --- head/sys/modules/Makefile Mon Jun 11 08:11:35 2018 (r334946) >> +++ head/sys/modules/Makefile Mon Jun 11 08:42:03 2018 (r334947) >> @@ -627,7 +627,9 @@ _aac= aac >> _aacraid= aacraid >> _acpi= acpi >> .if ${MK_CRYPT} != "no" || defined(ALL_MODULES) >> +.if ${COMPILER_TYPE} != "gcc" || ${COMPILER_VERSION} > 40201 >> _aesni= aesni >> +.endif >> .endif >> _amd_ecc_inject=amd_ecc_inject >> _amdsbwd= amdsbwd >> > > I thought that FreeBSD's base gcc (but not a stock 4.2.1 gcc) had support > for this. As documented in UPDATING: > > 20130903: > AES-NI intrinsic support has been added to gcc. The AES-NI module > has been updated to use this support. A new gcc is required to build > the aesni module on both i386 and amd64. > > -Kurt >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpX4hD8dPMQwOpNgBKH0hxAkdeRkVf=1f_PkeBPF64Gx1g>