Date: Wed, 5 Apr 2023 18:59:15 +0200 From: Moin Rahman <bofh@freebsd.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4cda17ab1458 - main - */*: Refactor java/openjdk7 removal Message-ID: <C6B9985A-B836-405E-9ED8-E0DDF4D85EFC@freebsd.org> In-Reply-To: <ZC2YSAqMmDW%2BgJF%2B@FreeBSD.org> References: <202304041811.334IB93k074119@gitrepo.freebsd.org> <ZC2YSAqMmDW%2BgJF%2B@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Apr 5, 2023, at 5:48 PM, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > > On Tue, Apr 04, 2023 at 06:11:09PM +0000, Muhammad Moinur Rahman wrote: >> commit 4cda17ab14588e6e4fdac7f697e246554ce82af3 >> >> Refactor java/openjdk7 removal >> >> - Since the introduction of jdk version 18 it looks like similar with >> jdk version 8(java version string 1.8). This is prone to error as it >> looks similar and is only seperated by a '.'. Remove using >> JAVA_VERSION with dotted fomat of java version string and update all >> consumers to utilize version 8 instead of 1.8. >> >> @@ -17,7 +17,7 @@ NO_WRKSUBDIR= yes >> >> USES= zip:infozip >> USE_JAVA= yes >> -JAVA_VERSION= 1.8+ >> +JAVA_VERSION= 8+ > > Perhaps we should drop JAVA_VERSION as USE_JAVA accepts versions similar > to USE_GCC; separate JAVA_VERSION is just a needless cognitive burden. > > ./danfe You speak my mind; but one step at a time. That is planned in step 2 and in step 3 I am going to convert this into USES=java. Kind regards, Moin [-- Attachment #2 --] <html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Apr 5, 2023, at 5:48 PM, Alexey Dokuchaev <<a href="mailto:danfe@FreeBSD.org" class="">danfe@FreeBSD.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">On Tue, Apr 04, 2023 at 06:11:09PM +0000, Muhammad Moinur Rahman wrote:<br class=""><blockquote type="cite" class="">commit 4cda17ab14588e6e4fdac7f697e246554ce82af3<br class=""><br class=""> Refactor java/openjdk7 removal<br class=""><br class=""> - Since the introduction of jdk version 18 it looks like similar with<br class=""> jdk version 8(java version string 1.8). This is prone to error as it<br class=""> looks similar and is only seperated by a '.'. Remove using<br class=""> JAVA_VERSION with dotted fomat of java version string and update all<br class=""> consumers to utilize version 8 instead of 1.8.<br class=""><br class="">@@ -17,7 +17,7 @@ NO_WRKSUBDIR=<span class="Apple-tab-span" style="white-space:pre"> </span>yes<br class=""><br class=""> USES=<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>zip:infozip<br class=""> USE_JAVA=<span class="Apple-tab-span" style="white-space:pre"> </span>yes<br class="">-JAVA_VERSION=<span class="Apple-tab-span" style="white-space:pre"> </span>1.8+<br class="">+JAVA_VERSION=<span class="Apple-tab-span" style="white-space:pre"> </span>8+<br class=""></blockquote><br class="">Perhaps we should drop JAVA_VERSION as USE_JAVA accepts versions similar<br class="">to USE_GCC; separate JAVA_VERSION is just a needless cognitive burden.<br class=""><br class="">./danfe<br class=""></div></div></blockquote></div><br class=""><div class="">You speak my mind; but one step at a time. That is planned in step 2 and in step 3 I am going to convert this into USES=java.</div><div class=""><br class=""></div><div class="">Kind regards,</div><div class="">Moin</div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C6B9985A-B836-405E-9ED8-E0DDF4D85EFC>