Date: Sun, 21 Dec 2014 12:56:54 -0700 From: Adam Weinberger <adamw@adamw.org> To: Steve Wills <swills@FreeBSD.org> Cc: "svn-ports-head@FreeBSD.org" <svn-ports-head@FreeBSD.org>, "svn-ports-all@FreeBSD.org" <svn-ports-all@FreeBSD.org>, "ports-committers@FreeBSD.org" <ports-committers@FreeBSD.org> Subject: Re: svn commit: r375010 - head/Mk Message-ID: <0C87C52E-BBE7-4C2A-819F-AF150F5A5ECD@adamw.org> In-Reply-To: <549722A1.8070104@FreeBSD.org> References: <201412201559.sBKFxl9d088764@svn.freebsd.org> <46210F48-0FE2-4B61-AA64-17472B9EAEEB@adamw.org> <549707F1.4070205@FreeBSD.org> <C23602A5-9FEA-4180-B469-4E098F16003C@adamw.org> <549722A1.8070104@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Dec 21, 2014, at 12:42, Steve Wills <swills@FreeBSD.org> wrote: >=20 >> On 12/21/14 19:28, Adam Weinberger wrote: >>=20 >>=20 >> Sure, same as other ports. Only difference is that, same as other >> ports, you don't need to come up with the commit SHA hash as well. >> You're portmgr, it's your call of course, I just thought it was a >> nice alternative for ports with release tarballs on github to use a >> simpler method. >=20 > I thought you were talking about ones that didn't use the GitHub release. >=20 > For ones that do use the GitHub release, making using those easier was > the goal of this commit. For example, after this commit, I can change > net/syncthing like so: >=20 > -MASTER_SITES=3D > https://github.com/${PORTNAME}/${PORTNAME}/archive/v${PORTVERSION}.tar.gz?= dummy=3D/ >=20 > +MASTER_SITES=3D GHR > +DISTVERSIONPREFIX=3D v > +USE_GITHUB=3D yes >=20 > No commit hash in either one. Also note there are some additional > changes for USE_GITHUB in the pipeline: >=20 > https://reviews.freebsd.org/D748 Oooh that's even better! I didn't pick that up when I saw the diff. Sorry ab= out the noise, I blame lack of coffee at the time. Can I suggest altering th= e PH or CHANGES to reflect the new behaviour? # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0C87C52E-BBE7-4C2A-819F-AF150F5A5ECD>