Date: Fri, 10 Feb 2017 16:34:35 -0800 From: John Baldwin <jhb@freebsd.org> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313564 - head/sys/kern Message-ID: <123901029.nPdTysnfLg@ralph.baldwin.cx> In-Reply-To: <E88B0F6E-D38C-4B08-B961-1D5E7BFE3742@gmail.com> References: <201702101925.v1AJPqhR022902@repo.freebsd.org> <2023305.EdEEquGYxm@ralph.baldwin.cx> <E88B0F6E-D38C-4B08-B961-1D5E7BFE3742@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, February 10, 2017 12:19:35 PM Ngie Cooper wrote: > > > On Feb 10, 2017, at 11:38, John Baldwin <jhb@freebsd.org> wrote: > > > > On Friday, February 10, 2017 07:25:52 PM John Baldwin wrote: > >> Author: jhb > >> Date: Fri Feb 10 19:25:52 2017 > >> New Revision: 313564 > >> URL: https://svnweb.freebsd.org/changeset/base/313564 > >> > >> Log: > >> Drop the "created from" line from files generated by makesyscalls.sh. > >> > >> This information is less useful when the generated files are included in > >> source control along with the source. If needed it can be reconstructed > >> from the $FreeBSD$ tag in the generated file. Removing this information > >> from the generated output permits committing the generated files along > >> with the change to the system call master list without having inconsistent > >> metadata in the generated files. > > > > There is a tradeoff of course. Having the generated files mixed in the > > commits does make the diff more noisy, and it can be more of a pain in reviews. > > One can still just not include the generated files when posting reviews (we > > already have to do that because you have to generate the files to do testing). > > > > However, I do think that at least for MFCs we should include the generated > > files in the merge so that on stable branches we don't have known-broken > > commits once this change is merged back to stable branches. > > Uhh…. $FreeBSD$ isn’t being expanded in some of these files… > > $ svn pg svn:keywords sys/sys/syscall.mk > FreeBSD=%H > $ grep '$FreeBSD' sys/sys/syscall.mk > # $FreeBSD$ Which client are you using? This is what I see on the clean checkout of head I comitted this from: % grep FreeBSD sys/sys/syscall.mk # FreeBSD system call object files. # $FreeBSD: head/sys/sys/syscall.mk 313566 2017-02-10 19:45:02Z jhb $ -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?123901029.nPdTysnfLg>