Date: Wed, 20 Apr 2005 16:34:02 -0400 From: Michael Johnson <ahze@ahze.net> To: Jeremy Messenger <mezz7@cox.net> Cc: gnome@freebsd.org Subject: Re: Can somebody please have a look at ports/78931? Message-ID: <4266BCBA.2070406@ahze.net> In-Reply-To: <op.spjqsimr9aq2h7@mezz.mezzweb.com> References: <20050420194825.76ebf3c0.flynn@energyhq.es.eu.org> <op.spjl56u59aq2h7@mezz.mezzweb.com> <20050420203250.597f6ae8.flynn@energyhq.es.eu.org> <op.spjqsimr9aq2h7@mezz.mezzweb.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigDA849FB797E848A7CBBA8062
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Jeremy Messenger wrote:
> On Wed, 20 Apr 2005 13:32:50 -0500, Miguel Mendez
> <flynn@energyhq.es.eu.org> wrote:
>
>> On Wed, 20 Apr 2005 13:11:56 -0500
>> "Jeremy Messenger" <mezz7@cox.net> wrote:
>>
>>> Not useful to me, but it's up to someone in my team if he likes OPTIONS
>>> stuff. Anyway, I took a bit look at it and I don't think few knobs will
>>
>>
>> Could you elaborate on why you don't think OPTIONS are useful? I'm
>> honestly interested.
>>
>>> work because of the OPTIONS don't work with the autocheck very well. I
>>> only see useful in your PR is that two knobs that have exist() should be
>>> move under .include <bsd.port.pre.mk> and change DATADIR in plist.
>>
>>
>> I did test builds with BATCH=yes and it worked fine. If there's
>> anything wrong I'd love to know about it.
>
>
> Nevermind, I thought the RSVG2 has '.if ${HAVE_GNOME:Mlibrsvg2}!=""'..
> The bsd.gnome.mk doesn't work with OPTIONS yet.
>
>> To make it clear: Whether the
>> consensus is to get it in the tree or drop it, it's fine. What I'd like
>> to avoid is to have the PR sitting in limbo for months.
>
>
> If nobody touch this PR for two more weeks or more maybe in May, then I
> will taking and commit it w/out add OPTIONS stuff then close it. That
> should give my team plenty of time if they want to add OPTIONS or make
> any comment on it.
Personally I don't like the idea of OPTIONS in gimp, well atleast not
all of them
ie. WITHOUT_JPEG, who is really going to use that OPTION.
Michael
>
> Cheers,
> Mezz
>
>> Cheers,
>
>
>
--------------enigDA849FB797E848A7CBBA8062
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFCZry6n4uqfTwEb9YRAkI8AJ43B4IUCFbj7RbJQkuiQrzB/THOyACgvGbu
urRgaKZljDCZcv6lnk+IZ14=
=URTC
-----END PGP SIGNATURE-----
--------------enigDA849FB797E848A7CBBA8062--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4266BCBA.2070406>