Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Nov 1998 11:14:53 +0000 (GMT)
From:      Doug Rabson <dfr@nlsystems.com>
To:        "Norman C. Rice" <nrice@emu.sourcee.com>
Cc:        Bruce Evans <bde@zeta.org.au>, mjacob@feral.com, current@FreeBSD.ORG
Subject:   Location for driver includes (was Re: Breakage in -current for theALPHA)
Message-ID:  <Pine.BSF.4.01.9811241056140.21711-100000@herring.nlsystems.com>
In-Reply-To: <19981123214901.A13260@emu.sourcee.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 23 Nov 1998, Norman C. Rice wrote:

> On Tue, Nov 24, 1998 at 03:16:57AM +1100, Bruce Evans wrote:
> > >> They traditionally go in sys (e.g., ttycom.h).  Of course, there is
> > >> no such thing as a machine independant driver API.  There isn't even
> > >> such a thing as a machine independent driver API.
> > >
> > >Eh? The second sentence might have been 'machine *dependent*'?
> > >
> > >In either case, what do you mean? There most certainly is both a DDI and
> > >DKI for *BSD. There are MI functions (even in FreeBSD which is
> > >historically less sensitive to MI vs MD issues) such as bcopy (DKI) or
> > >devswitch functions. There are MD functions such as isa_configure (DDI).
> > 
> > 1. Mispelling of `dependent' is annoying.
>      ^^^^^^^^^^
> The misspelling of `misspelling' when trying to make a point
> about correct spelling is also annoying. :)
> -- 
> Regards,
> Norman C. Rice, Jr.
> 
> > 2. Nothing is really machine independent.
> > 
> > Bruce

Ok, now that everyone has got their pedantry out of the way, can we please
have a discussion about driver include files.  The fact is that several
architectures (including both of our supported arches) use the same
hardware and having driver sources in sys/i386/isa and driver includes in
sys/i386/include is just plain wrong.  At this point we have two
suggestions for locations of driver includes (sys/sys and sys/dev/include)
and no suggestions for driver sources.

I'm not too keen on dumping all the driver includes in sys/sys since its
pretty crowded already.  NetBSD appears to have some headers in there and
some in the machine's include directory.  I don't really have any strong
arguments here but I would prefer that only 'generic' apis go here (all
the ones currently there are).

Is it worth sorting includes based on the type of bus which the hardware
is attached to?  Something like:

	sys/dev/include			non-bus-specific includes
	sys/dev/include/isa		isa bus includes
	sys/dev/include/pci		pci bus includes
	...

--
Doug Rabson				Mail:  dfr@nlsystems.com
Nonlinear Systems Ltd.			Phone: +44 181 951 1891
					Fax:   +44 181 381 1039


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.01.9811241056140.21711-100000>