Date: Fri, 22 Mar 2013 01:56:09 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Beech Rintoul <beech@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r314866 - head/graphics/piddle Message-ID: <20130322015609.GB17285@FreeBSD.org> In-Reply-To: <201303211953.r2LJrG9c004938@svn.freebsd.org> References: <201303211953.r2LJrG9c004938@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 21, 2013 at 07:53:16PM +0000, Beech Rintoul wrote: > New Revision: 314866 > URL: http://svnweb.freebsd.org/changeset/ports/314866 > > +.if ${PORT_OPTIONS:MDOCS} > + (cd ${WRKSRC}/docs && ${COPYTREE_SHARE} \* ${DOCSDIR}) May I bring your attention one more time to the fact that using a dot instead of asterisk has several advantages while achieving the same thing: - dot is not a subject to shell expansion, thus being generally safer - consequently, dot does not have to be escaped - dot is one character shorter and more readable (escaping commonly reduces readability in Unix constructs) I think I've already made similar observations few days ago, which somehow went unanswered. If there's a flaw in my reasoning, please speak up, thanks! ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130322015609.GB17285>