Date: Fri, 3 Mar 2017 06:53:10 +0000 From: "smh (Steven Hartland)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: <2488742d8120ee5758ec7e34a7f644a9@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-ml6ban3epmjn5plj7t5q-req@FreeBSD.org> References: <differential-rev-PHID-DREV-ml6ban3epmjn5plj7t5q-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
smh added inline comments.
INLINE COMMENTS
> pxe.c:296
> +
> + if (dhcp_try_rfc1048(bootplayer.vendor.d, BOOTP_DHCPVEND)) {
> + if (pxe_debug)
Didn't spot this before but does this need a more explicit test as this method returns and isn't not a book and it's not clear what's the -1 is meant to trigger and how it's dealt with here?
REVISION DETAIL
https://reviews.freebsd.org/D9847
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: kczekirda, oshogbo, bapt, tsoome, glebius, freebsd-net-list, #network, gnn, smh
Cc: smh
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2488742d8120ee5758ec7e34a7f644a9>