Date: Mon, 21 Dec 2009 20:49:59 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: dougb@FreeBSD.org Cc: svn-src-head@FreeBSD.org, des@des.no, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, jhb@FreeBSD.org Subject: Re: svn commit: r200606 - in head/sys: compat/freebsd32 sys Message-ID: <20091221.204959.104237699577179806.imp@bsdimp.com> In-Reply-To: <4B2C127A.8060509@FreeBSD.org> References: <200912161541.53834.jhb@freebsd.org> <868wd0cyjd.fsf@ds4.des.no> <4B2C127A.8060509@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <4B2C127A.8060509@FreeBSD.org>
Doug Barton <dougb@FreeBSD.org> writes:
: Dag-Erling Smørgrav wrote:
: > John Baldwin <jhb@freebsd.org> writes:
: >> Warner Losh <imp@freebsd.org> writes:
: >>> Log:
: >>> Fix compiling FREEBSD_COMPAT[4,5,6] without FREEBSD_COMPAT7.
: >>>
: >>> Note: Not sure this is the right way to do compat, but it makes the
: >>> headers consistent with the implementations.
: >> Please revert. I think this has already been reverted once before.
: >
: > Yep, that was me... we concluded back then that this is a perfectly
: > reasonable dependency; perhaps we should simply add the appropriate
: > #ifndef / #error constructs so you can't define FREEBSD_COMPAT(n)
: > without FREEBSD_COMPAT(n+1).
:
: Trying to look at this from the user perspective, it's kind of silly
: that if what I want is COMPAT5 I also need to add COMPAT<somethingelse>.
:
: I don't know the issues in the code so I don't know what the solution
: should be on the back end, but on the front end what needs to work is
: that I specify the compat level I want in my kernel config, then the
: code does what's necessary to make that work.
The trouble is that we need to do this globally, or certain
definitions don't get defined. It is easier to just #error out than
hack config to do the right thing I think...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091221.204959.104237699577179806.imp>