Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 May 2000 16:46:51 +0200
From:      Johan Karlsson <k@numeri.campus.luth.se>
To:        Alexander Langer <alex@big.endian.de>
Cc:        hackers@FreeBSD.ORG
Subject:   Re: review request: truncate(1) 
Message-ID:  <200005251446.QAA12958@numeri.campus.luth.se>
In-Reply-To: Your message of "Thu, 25 May 2000 14:18:17 %2B0200." <20000525141817.A17484@cichlids.cichlids.com> 

next in thread | previous in thread | raw e-mail | index | archive | help
At Thu, 25 May 2000 14:18:17 +0200, Alexander Langer wrote:
>Hello!
>
>I've written the command-line frontend to truncate(2).
>I've often needed that since now, and finally I wrote it.
>
>I'm sure it's useful.
>
>Please review (includes source, manpage + Makefile).
>
>http://big.endian.de/FreeBSD/truncate.tar.gz
>
>Thanks
>

Hi
Please sort the options in getopt and in the switch-statement.

see style(9) for more style info.


Please also use -Wall when compiling to catch all warnings
(add 
CFLAGS += -Wall
to your Makefile).


/Johan K


>Alex
>-- 
>I need a new ~/.sig.
>
>
>To Unsubscribe: send mail to majordomo@FreeBSD.org
>with "unsubscribe freebsd-hackers" in the body of the message
>




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200005251446.QAA12958>