Date: Mon, 26 Sep 2005 12:31:29 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern subr_prf.c Message-ID: <20050926123058.X11229@fledge.watson.org> In-Reply-To: <20050926212051.J21547@delplex.bde.org> References: <200509260802.j8Q82PFW064658@repoman.freebsd.org> <20050926212051.J21547@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 26 Sep 2005, Bruce Evans wrote: >> Acquire Giant in uprintf() and tprintf() rather than asserting it. In >> the vast majority of cases, these functions are called without mutexes >> held, meaning that in all but two cases, there will be no ordering >> issues with doing this, and it will eliminate the need for changes in >> the caller. In two cases, mutexes are held, so Giant must be acquired >> before those mutexes such that uprintf() and tprintf() recurse Giant >> rather than generating a lock order reversal. > > Thansks. I'll take a jaunt through the rest of the tree removing the Giant acquisitions (in most cases) later this afternoon (local time) Robert N M Watson
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050926123058.X11229>