Date: Sat, 19 Mar 2016 19:22:57 +0100 From: Jan Beich <jbeich@vfemail.net> To: Thomas Zander <riggs@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r411417 - in head/multimedia: . libdcadec Message-ID: <vb4i-5num-wny@vfemail.net> In-Reply-To: <201603191745.u2JHjOqA065172@repo.freebsd.org> (Thomas Zander's message of "Sat, 19 Mar 2016 17:45:24 %2B0000 (UTC)") References: <201603191745.u2JHjOqA065172@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
(Simple ports tend to have more style issues, paradoxically)
Thomas Zander <riggs@FreeBSD.org> writes:
> +GH_TAGNAME=3D v${PORTVERSION}
Convert to DISTVERSIONPREFIX and re-run |make makesum|. It should
remove version duplication from distinfo.
> +NO_CONFIGURE=3D yes
Why? bsd.port.mk explicitly says there's no such variable.
> +USES=3D pkgconfig gmake
Maybe sort.
> +LDFLAGS+=3D -lm
Maybe use LIBS to undo MAKE_ENV damage.
> + -e 's;$$(LIBDIR)/pkgconfig;$$(PREFIX)/libdata/pkgconfig;' \
Maybe convert to
USES=3D ... pathfix
PATHFIX_MAKEFILEIN=3D Makefile
> ${REINPLACE_CMD} -e 's;INCLUDEDIR;MYINCLUDEDIR;g' \
> -e 's;LIBDIR;MYLIBDIR;g' \
> ${WRKSRC}/dcadec.pc.in \
> ${WRKSRC}/Makefile
MAKE_ARGS would be shorter.
Index: multimedia/libdcadec/Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- multimedia/libdcadec/Makefile (revision 411417)
+++ multimedia/libdcadec/Makefile (working copy)
@@ -2,6 +2,7 @@
=20
PORTNAME=3D libdcadec
PORTVERSION=3D 0.2.0
+DISTVERSIONPREFIX=3D v
CATEGORIES=3D multimedia
=20
MAINTAINER=3D mickael.maillot@gmail.com
@@ -12,22 +13,15 @@ LICENSE=3D LGPL21
USE_GITHUB=3D yes
GH_ACCOUNT=3D foo86
GH_PROJECT=3D dcadec
=2DGH_TAGNAME=3D v${PORTVERSION}
=20
=2DNO_CONFIGURE=3D yes
=2DUSES=3D pkgconfig gmake
=2DLDFLAGS+=3D -lm
+USES=3D gmake pathfix pkgconfig
+PATHFIX_MAKEFILEIN=3D Makefile
MAKE_ENV+=3D CONFIG_SHARED=3Dyes
+MAKE_ARGS+=3D INCLUDEDIR=3D"${PREFIX}/include" LIBDIR=3D"${PREFIX}/lib"
+LIBS+=3D -lm
=20
USE_LDCONFIG=3D yes
=20
=2Dpost-patch:
=2D ${REINPLACE_CMD} -e 's;INCLUDEDIR;MYINCLUDEDIR;g' \
=2D -e 's;$$(LIBDIR)/pkgconfig;$$(PREFIX)/libdata/pkgconfig;' \
=2D -e 's;LIBDIR;MYLIBDIR;g' \
=2D ${WRKSRC}/dcadec.pc.in \
=2D ${WRKSRC}/Makefile
=2D
post-install:
${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/dcadec
${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/${PORTNAME}.so.0.1.0
Index: multimedia/libdcadec/distinfo
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- multimedia/libdcadec/distinfo (revision 411417)
+++ multimedia/libdcadec/distinfo (working copy)
@@ -1,2 +1,2 @@
=2DSHA256 (foo86-dcadec-0.2.0-v0.2.0_GH0.tar.gz) =3D ed9d207fde3e8d576f3af8=
b0d1235b3371e315175757173689104efcaebf0d44
=2DSIZE (foo86-dcadec-0.2.0-v0.2.0_GH0.tar.gz) =3D 225305
+SHA256 (foo86-dcadec-v0.2.0_GH0.tar.gz) =3D ed9d207fde3e8d576f3af8b0d1235b=
3371e315175757173689104efcaebf0d44
+SIZE (foo86-dcadec-v0.2.0_GH0.tar.gz) =3D 225305
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQF8BAEBCgBmBQJW7ZkCXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bXy8H/RXcxaAN9Aa+Ymh/yCWuu0/4
o5Tryw0uTglX7R03o7qzAEhrs96wXcxm5GhTv6po4xBcxbxou8Py4mztPXGrHsuP
/+wdzuE/3+STG/ISpQtS8nAebEudrDPjm+CftAiaI0fbcf9RU4NLozLpCPbe5yHx
HOPx2rQzENCyDvQqfCX4xLdBVbZy1IaF0jvrRBktG/x93R/IHTMtWJ+g2qTuns+H
CYBDgsLwmnrUrDXS61XxbIKJijCdGXBX5eBK6kKgRRNmFgG85ATuDjNAo3LMv/9Q
NiyOXjA/etFYVGCpA+N+EwkRfO0RudW2qn7NraAfUjcm2KMqGvLXPrGw5XWkDiQ=
=k2Je
-----END PGP SIGNATURE-----
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?vb4i-5num-wny>