Date: Thu, 6 Oct 2016 15:37:42 +0200 From: Franco Fichtner <franco@lastsummer.de> To: Kristof Provost <kp@freebsd.org> Cc: Mark Martinec <Mark.Martinec+freebsd@ijs.si>, freebsd-pf@freebsd.org Subject: Re: dscp set/get Message-ID: <AA274187-6F5D-4B96-9529-939EC30CB699@lastsummer.de> In-Reply-To: <E227CD94-66E0-4DFE-91F4-67F2DDEDE9BD@FreeBSD.org> References: <57F5D9D2.1060103@norma.perm.ru> <311888F1-3BD6-4C4E-818D-C4A9C00B55ED@FreeBSD.org> <C1F20DD6-5B32-4856-A2F7-7DAFB38E4D3A@lastsummer.de> <C539471F-8C0C-4BCD-815C-D449EF1427DB@FreeBSD.org> <bbfc73f2096ac204a752a800c2863e97@mailbox.ijs.si> <E227CD94-66E0-4DFE-91F4-67F2DDEDE9BD@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 06 Oct 2016, at 3:32 PM, Kristof Provost <kp@freebsd.org> wrote: >=20 > On 6 Oct 2016, at 15:01, Mark Martinec wrote: >> Just adding recognition to a parser for a couple of DSCP constants >> to be mapped to TOS is not the solution. Keep in mind that DSCP >> is a 6-bit field, and TOS is an 8-bit field. The remaining two bits >> are used for ECN (Explicit Congestion Notification). >>=20 >> Setting TOS field with the intention of changing DSCP >> clobbers ECN bits. Pf needs a proper support for DSCP, >> currently it is unusable for this purpose in FreeBSD >> (one can use the PF from OpenBSD). >>=20 >=20 > Hmm, that=E2=80=99s a good point. That's two one-liners, one for set and one for match? Surprised that this wasn't included already. > OpenBSD seem to just always preserve the ECN bits (so there=E2=80=99s = no dscp keyword). > Perhaps we should do the same. I have a full patch for review tonight. Cheers, Franco
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AA274187-6F5D-4B96-9529-939EC30CB699>