Skip site navigation (1)Skip section navigation (2) 
Date:      Sat, 6 Jun 2009 00:52:25 +0000 (UTC)
From:      Kip Macy <kmacy@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r193558 - user/kmacy/releng_7_2_fcs/sys/dev/cxgb
Message-ID:  <200906060052.n560qPPB043462@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: kmacy
Date: Sat Jun  6 00:52:25 2009
New Revision: 193558
URL: http://svn.freebsd.org/changeset/base/193558

Log:
  - simplify cxgb_dequeue_chain
  - add sanity check

Modified:
  user/kmacy/releng_7_2_fcs/sys/dev/cxgb/cxgb_sge.c

Modified: user/kmacy/releng_7_2_fcs/sys/dev/cxgb/cxgb_sge.c
==============================================================================
--- user/kmacy/releng_7_2_fcs/sys/dev/cxgb/cxgb_sge.c	Sat Jun  6 00:49:49 2009	(r193557)
+++ user/kmacy/releng_7_2_fcs/sys/dev/cxgb/cxgb_sge.c	Sat Jun  6 00:52:25 2009	(r193558)
@@ -1509,12 +1509,13 @@ coalesce_check(struct mbuf *m, void *arg
 }
 
 static struct mbuf *
-cxgb_dequeue_chain(struct sge_qset *qs, struct coalesce_info *ci)
+cxgb_dequeue_chain(struct sge_qset *qs)
 {
 	struct mbuf *m, *m_head, *m_tail;
+	struct coalesce_info ci;
 
 	m_head = m_tail = NULL;
-	ci->count = ci->nbytes = 0;
+	ci.count = ci.nbytes = 0;
 	do {
 		m = TXQ_RING_DEQUEUE_COND(qs, coalesce_check, &ci);
 		if (m_head == NULL) {
@@ -1524,7 +1525,8 @@ cxgb_dequeue_chain(struct sge_qset *qs, 
 			m_tail = m;
 		}
 	} while (m != NULL);
-	
+	if (ci.count > 7)
+		panic("trying to coalesce %d packets in to one WR", ci.count);
 	return (m_head);
 }
 	
@@ -1538,7 +1540,6 @@ cxgb_start_locked(struct sge_qset *qs)
 	struct port_info *pi = qs->port;
 	struct adapter *sc = pi->adapter;
 	struct ifnet *ifp = pi->ifp;
-	struct coalesce_info ci;
 
 	avail = txq->size - txq->in_use - 4;
 	txmax = min(TX_START_MAX_DESC, avail);
@@ -1550,7 +1551,7 @@ cxgb_start_locked(struct sge_qset *qs)
 		check_pkt_coalesce(qs);
 
 		if (sc->tunq_coalesce) {
-			m_head = cxgb_dequeue_chain(qs, &ci);
+			m_head = cxgb_dequeue_chain(qs);
 		} else 
 			m_head = TXQ_RING_DEQUEUE(qs);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906060052.n560qPPB043462>