Date: Mon, 3 Oct 2016 11:03:11 -0700 From: Marcel Moolenaar <marcel@xcllnt.net> To: Marcel Moolenaar <marcel@freebsd.org>, cem@freebsd.org Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r306620 - head/usr.bin/mkimg Message-ID: <etPan.57f29d60.1fcacfa2.6f1a@xcllnt.net> In-Reply-To: <CAG6CVpWTDsBFEWd1GDaQZ%2BTnY7Ltw945Wf5T6RwqMeh-G_j_cg@mail.gmail.com> References: <201610030146.u931klQS063311@repo.freebsd.org> <CAG6CVpWTDsBFEWd1GDaQZ%2BTnY7Ltw945Wf5T6RwqMeh-G_j_cg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On October 3, 2016 at 10:36:27 AM, Conrad Meyer (cem@freebsd.org) wrote: On Sun, Oct 2, 2016 at 6:46 PM, Marcel Moolenaar <marcel@freebsd.org> wrote: > Author: marcel > Date: Mon Oct 3 01:46:47 2016 > New Revision: 306620 > URL: https://svnweb.freebsd.org/changeset/base/306620 > > Log: > Replace STAILQ with TAILQ. TAILQs are portable enough that they can > be used on both macOS and Linux. STAILQs are not. In particular, > STAILQ_LAST does not next on Linux. Since neither STAILQ_FOREACH_SAFE > nor TAILQ_FOREACH_SAFE exist on Linux, replace its use with a regular > TAILQ_FOREACH. The _SAFE variant was only used for having the next > pointer in a local variable. All of these routines are available in the "libbsd" sys/queue.h. You might find other helpful portability/compatibility routines there, requiring fewer changes to the FreeBSD mkimg. Oh, nice. I’ll take a look. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJX8p1gAAoJEIda8t8f0tjj3oUQAOkZXml43xfdURFUkHXVjp7i Jd7440BA3/ZSxnnQ3hDFzJgZJ9ZNOcQ3XLUwAbYjHVkT3aItY/aKl4BbUMhgmY7W Kkes9iN0fQELu/QsA/kN+uu48hc8RzPKZibzRuiV1q4XN5iiEcKq3nutWab1U1vl tpIhG2tOgTj0Mm9jZ2UQ+u4xhajtTTo8IMDrrGIRryLD28JIjOooCfvkcqfsfx6d O7x63JZdMpgCcKpsR6Lp99/86VNNq8BW68HFtyppXQ0KjBr/TxZvqr6pZiG/kjrC Ca8rhMMbY4AXHX65U7X6EJDYOvUELCpyuUC+1ERLDLpLQmnaHZrZxyFzz3Se3Gfi wONq3XU2+LQ7lI9GolHIJf8nKB1xF7AMiiy4aEWttjCBhuM54C+mqjsnZ12lMdhU ZvdMEq6kxuiuodLszG/54l/a9u5c9dyB12mETbUlm2J1HDHu0JK36XRL3ZDICfFg g2xSm8aImnLH52/AKIEPgHlLS2Pg8FzKlllxZvjimd2mSVhMGlIjS6kt1A+/wW0f l1CFKZm43izMIiqrkbsj3fO4ul5pAQjzGxOtlrI4g0Ktn5h5QxDpBMUa6r1Xju3m 0MBWB80ySlHY1u9H6K7/QMLR/Pl/bKI8zqDDZAoohFgNqSA0kPbJfWJtuHzLO0AW hQ/2tQJkPx+18rSHeYw8 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?etPan.57f29d60.1fcacfa2.6f1a>