Date: Mon, 2 Aug 2021 23:48:01 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Alexander Motin <mav@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 74f80bc1af2f - main - coretemp(4): Switch to smp_rendezvous_cpus(). Message-ID: <YQhaAQGs2giP/ISy@kib.kiev.ua> In-Reply-To: <5b8b9ee4-4c90-ed32-de37-9d03fd812550@FreeBSD.org> References: <202107300326.16U3QGHR070204@gitrepo.freebsd.org> <YQVGn7VhKstcGndr@kib.kiev.ua> <5b8b9ee4-4c90-ed32-de37-9d03fd812550@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 02, 2021 at 12:15:55PM -0400, Alexander Motin wrote:
> On 31.07.2021 08:48, Konstantin Belousov wrote:
> >> +static void
> >> +coretemp_wrmsr(void *arg)
> >> +{
> >> + struct coretemp_args *args = arg;
> >> +
> >> + wrmsr(args->msr, args->val);
> >> +}
> > We have x86_msr_op(). It covers coretemp_wrmsr(), and with slight
> > change of the interface would also handle the functionality of
> > coretemp_rdmsr().
>
> As I see x86_msr_op() is tuned for MSR modification on all CPUs, while
> this code touches one CPU at a time.
https://reviews.freebsd.org/D31386
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YQhaAQGs2giP/ISy>