Date: Thu, 25 Nov 2004 10:01:26 +0000 (UTC) From: Hartmut Brandt <harti@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/usr.bin/make job.c Message-ID: <200411251001.iAPA1Qd6013190@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
harti 2004-11-25 10:01:26 UTC
FreeBSD src repository
Modified files:
usr.bin/make job.c
Log:
Fix a very long-standing error in handling .SHELL targets: this target
uses the brk_string function to parse the line. That function uses static
storage for both the expanded string and the returned argv[] vector.
The JobParseShell function simply stored away pointers into this static
storage. On the next use of something like ${FOO:O} this storage would
get overwritten with fatal results.
This also allows us to make the shells[] array const bringing us one step
further in making make WARNS=4 ready.
Revision Changes Path
1.60 +125 -46 src/usr.bin/make/job.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200411251001.iAPA1Qd6013190>