Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 17 Jun 2015 19:12:18 +0000 (UTC)
From:      Xin LI <delphij@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r284524 - stable/10/lib/libc/locale
Message-ID:  <201506171912.t5HJCI8k075515@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: delphij
Date: Wed Jun 17 19:12:18 2015
New Revision: 284524
URL: https://svnweb.freebsd.org/changeset/base/284524

Log:
  MFC r264038 (theraven):
  
  Fix an issue where the locale and rune locale could become out of sync,
  causing mb* functions (and similar) to be called with the wrong data
  (possibly a null pointer, causing a crash).
  
  PR:		standards/188036

Modified:
  stable/10/lib/libc/locale/setrunelocale.c
  stable/10/lib/libc/locale/xlocale.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/lib/libc/locale/setrunelocale.c
==============================================================================
--- stable/10/lib/libc/locale/setrunelocale.c	Wed Jun 17 19:03:32 2015	(r284523)
+++ stable/10/lib/libc/locale/setrunelocale.c	Wed Jun 17 19:12:18 2015	(r284524)
@@ -202,6 +202,8 @@ __set_thread_rune_locale(locale_t loc)
 
 	if (loc == NULL) {
 		_ThreadRuneLocale = &_DefaultRuneLocale;
+	} else if (loc == LC_GLOBAL_LOCALE) {
+		_ThreadRuneLocale = 0;
 	} else {
 		_ThreadRuneLocale = XLOCALE_CTYPE(loc)->runes;
 	}

Modified: stable/10/lib/libc/locale/xlocale.c
==============================================================================
--- stable/10/lib/libc/locale/xlocale.c	Wed Jun 17 19:03:32 2015	(r284523)
+++ stable/10/lib/libc/locale/xlocale.c	Wed Jun 17 19:12:18 2015	(r284524)
@@ -154,23 +154,24 @@ __get_locale(void)
 static void
 set_thread_locale(locale_t loc)
 {
+	locale_t l = (loc == LC_GLOBAL_LOCALE) ? 0 : loc;
 
 	_once(&once_control, init_key);
 	
-	if (NULL != loc) {
-		xlocale_retain((struct xlocale_refcounted*)loc);
+	if (NULL != l) {
+		xlocale_retain((struct xlocale_refcounted*)l);
 	}
 	locale_t old = pthread_getspecific(locale_info_key);
-	if ((NULL != old) && (loc != old)) {
+	if ((NULL != old) && (l != old)) {
 		xlocale_release((struct xlocale_refcounted*)old);
 	}
 	if (fake_tls) {
-		thread_local_locale = loc;
+		thread_local_locale = l;
 	} else {
-		pthread_setspecific(locale_info_key, loc);
+		pthread_setspecific(locale_info_key, l);
 	}
 #ifndef __NO_TLS
-	__thread_locale = loc;
+	__thread_locale = l;
 	__set_thread_rune_locale(loc);
 #endif
 }
@@ -361,9 +362,6 @@ locale_t uselocale(locale_t loc)
 {
 	locale_t old = get_thread_locale();
 	if (NULL != loc) {
-		if (LC_GLOBAL_LOCALE == loc) {
-			loc = NULL;
-		}
 		set_thread_locale(loc);
 	}
 	return (old ? old : LC_GLOBAL_LOCALE);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201506171912.t5HJCI8k075515>