Date: Thu, 27 Apr 2006 17:17:46 +0300 From: Giorgos Keramidas <keramida@FreeBSD.org> To: Jiawei Ye <leafy7382@gmail.com> Cc: John-Mark Gurney <jmg@FreeBSD.org>, freebsd-current@FreeBSD.org Subject: Re: top(1) stopped working on -current Message-ID: <20060427141745.GA74340@gothmog.pc> In-Reply-To: <20060427141318.GA74140@gothmog.pc> References: <c21e92e20604262342v31c440bah7ad79a8c679fb134@mail.gmail.com> <20060427141318.GA74140@gothmog.pc>
next in thread | previous in thread | raw e-mail | index | archive | help
--J2SCkAp4GZ/dPZZf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On 2006-04-27 17:13, Giorgos Keramidas <keramida@FreeBSD.org> wrote:
> # --- src/sys/kern/sched_4bsd.c (revision 19)
> # +++ src/sys/kern/sched_4bsd.c (working copy)
> # @@ -31,11 +31,11 @@
> # * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> # * SUCH DAMAGE.
> # */
> #
> # #include <sys/cdefs.h>
> # -__FBSDID("$FreeBSD: src/sys/kern/sched_4bsd.c,v 1.78 2006/04/17 18:20:37 jhb Exp $");
> # +__FBSDID("$FreeBSD: src/sys/kern/sched_4bsd.c,v 1.79 2006/04/26 19:42:38 jmg Exp $");
> #
> # [...]
>
> The main problems with this change are:
>
> 1) It doesn't update consumers of the kern.ccpu sysctl that we
> already have in the tree (i.e. top(1) which you saw breaking).
FWIW, the current consumers of `kern.ccpu' are:
giorgos@gothmog:~/ws/bsd/src$ fgrep -r kern.ccpu .
./bin/ps/nlist.c: if (sysctlbyname("kern.ccpu", &ccpu, &oldlen, NULL, 0) == -1)
./usr.bin/systat/pigs.c: err = sysctlbyname("kern.ccpu", &ccpu, &len, NULL, 0);
./usr.bin/systat/pigs.c: perror("kern.ccpu");
./usr.bin/top/machine.c: GETSYSCTL("kern.ccpu", ccpu);
./usr.sbin/bsnmpd/modules/snmp_hostres/hostres_processor_tbl.c: if (sysctlbyname("kern.ccpu", &ccpu, &len, NULL, 0) == -1) {
./usr.sbin/bsnmpd/modules/snmp_hostres/hostres_processor_tbl.c: syslog(LOG_ERR, "hrProcessorTable: sysctl(kern.ccpu) failed");
giorgos@gothmog:~/ws/bsd/src$
--J2SCkAp4GZ/dPZZf
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (FreeBSD)
iD8DBQFEUNKJ1g+UGjGGA7YRAk1SAKC8VhEL8q6SmmvF+aCmzQs7LC/8XACgh/t3
D4Xl1HvnuD6oAPnm4Larnlo=
=QSmm
-----END PGP SIGNATURE-----
--J2SCkAp4GZ/dPZZf--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060427141745.GA74340>