Date: Mon, 14 Jul 2003 02:32:55 -0700 From: Kris Kennaway <kris@obsecurity.org> To: Volker Stolz <vs@foldr.org> Cc: ports-committers@freebsd.org Subject: Re: (fwd) Re: cvs commit: ports/x11-toolkits/open-motif/files patch-lib::Xm::ColorS.c Message-ID: <20030714093255.GA14960@rot13.obsecurity.org> In-Reply-To: <20030714092911.GB3714@theater.foldr.org> References: <20030714072236.GK14622@fump.kawo2.rwth-aachen.de> <20030714092911.GB3714@theater.foldr.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Jul 14, 2003 at 11:29:11AM +0200, Volker Stolz wrote: > On Mon, Jul 14, 2003 at 09:22:36AM +0200, Alexander Langer wrote: > > ----- Forwarded message from Kris Kennaway <kris@obsecurity.org> ----- > > > 'colordemo' from open-motif can be used to select colors by either RGB values > > > or from the file rgb.txt. However, the underlying library doesn't honour XBASE > > > and looks for the file in the wrong place. > > > > > Are you sure this patch is correct? How does X11BASE get transmuted > > into LIBDIR (which defaults to /usr/lib)? > > LIBDIR gets set in the Makefile by means of configure and is handled in the same > way in similar places throughout the source, e.g. openmotif-2.2.2/lib/Xm/Xmos.c > I added the #ifndef LIBDIR lines so that in case somebody else picks up our patches or > chooses to configure this thing in a different way, he gets the behaviour of the > original source code. Notice the -DLIBDIR in the actual command being executed from the > FreeBSD port: > > cc -DHAVE_CONFIG_H -I. -I. -I../../include -I./.. -DXMBINDDIR_FALLBACK=\"/usr/X11R6/lib/X11/bindings\" -DINCDIR=\"/usr/X11R6/include/X11\" -DLIBDIR=\"/usr/X11R6/lib/X11\" -I/usr/X11R6/include -DCSRG_BASED -DXUSE_MTSAFE_API -DXNO_MTSAFE_PWDAPI -O -pipe -O -pipe -W -march=pentiumpro -Wall -Wno-unused -Wno-comment -c ColorS.c -fPIC -DPIC -o .libs/ColorS.lo > > Do you see a specific case where this breaks? OK, that looks fine. I didn't see LIBDIR being set in the port makefile or patches, so I assumed that the configure script wouldn't set it to a different default value than that used in the source. Kris [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (FreeBSD) iD8DBQE/EnjGWry0BWjoQKURAmmuAKCh9PjQwSesffGYIXig0fg8pIhpNACaA2Kr 5QfSs013Rjb72HElEpfhD8g= =OBed -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030714093255.GA14960>