Date: Wed, 30 Apr 2014 09:24:49 -0600 From: Warner Losh <imp@bsdimp.com> To: Thomas Skibo <ThomasSkibo@sbcglobal.net> Cc: freebsd-arm <freebsd-arm@FreeBSD.org>, Ian Lepore <ian@FreeBSD.org> Subject: Re: sdhci_fdt ignores clock-frequency property in .dtb Message-ID: <D4FC3928-BDC8-4E0E-9631-E1C23521F711@bsdimp.com> In-Reply-To: <53610CB6.6000003@sbcglobal.net> References: <53601B1D.2090702@sbcglobal.net> <1398816332.22079.49.camel@revolution.hippie.lan> <53610CB6.6000003@sbcglobal.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] http://svnweb.freebsd.org/base/vendor/device-tree/dist/Bindings/mmc/mmc.txt?revision=262573&view=markup has the standard which we try to follow (but sometimes fall short) on. There’s several properties we currently ignore, but perhaps shouldn’t. Warner On Apr 30, 2014, at 8:46 AM, Thomas Skibo <ThomasSkibo@sbcglobal.net> wrote: > > It looks like one other platform uses sdhci_fdt: exynos5250 (Chromebook). See exynos5250.dtsi. The "/* TODO: verify freq */" comment leads me to think they noticed that property wasn't working. > > I'm okay with max-frequency. I can generate a new patch. > > On 4/29/14, 5:05 PM, Ian Lepore wrote: >> On Tue, 2014-04-29 at 14:35 -0700, Thomas Skibo wrote: >>> Another Zynq bug-fix. One Zynq board out there needs to set this >>> property or else the SD card gets clocked too fast. >>> >>> Thanks, >>> >> >> The documented property for this is max-frequency rather than >> clock-frequency. Is this a completely new property for us, or are you >> just making the code honor what's in our existing dts files? Either way >> we should use the documented name, I'm just wondering if we need to fix >> dts files and give folks a heads-up about the change. >> >> -- Ian >> >> >> > > -- > -------- > Thomas Skibo > ThomasSkibo@sbcglobal.net > > _______________________________________________ > freebsd-arm@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arm > To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org" [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTYRXBAAoJEGwc0Sh9sBEA3GYP/0SuS3huBjZ9wfKjYk9ZNlEx pN2qlzCp90eYJy54NgYPJS5jR8vhXYEGvX4rSn81ip4hFTEoNXZ4QWCVZ7zq1l+O uIt7DkvTqzWYa73A3uo6ZwhvCXuzo1jzMYvZXhyFI06/ffRmsPwb37Jc1zcF0AiK UEDwG7eTQQyVoPXbX7awGU8onYprxUjs0Z0UX7jJ8+wEEOAJUVyovavNoFyAovfm BhI+A1Q7bHD73dDUwgNrf4V3usVpaODpVKj91GXfbt/BK14mbrQaSuJ1BSjkHdZV NVOND1mSm2rg0XCBh0F+KE+ce3GAXBNbGML5+gsJFRWreIob8UMQHIke2rF8rQuB 7uA1pqNhYAHIfaUgflHD1kInHe0vxeJtwhALTIkxLnubCsbEdlh3jqILPGkaRe8T VFzMizChfVBC0vQa1h4yBaZZOv9RKoZYufwtmhmLIzhU7kKKN7sT8nYLfGnl209L nUp39vfypASNY536/RQ65qtVXKhzqg0PdsKrH8nussrBQ11AvojKMlRHUdPGXPIK dFT1JwcvaVqCpC2Zp83qv64c4LkDunM26Iee5tO+E5C6xNfKPju+HHBFxTRU7xoP sNkVH0zN6DHcbQ8G9pGJMpGEmhp/q1Raw/ALjdOtP6nr5yeWu6M4iFC+iHFn+ydh gmWUHKC865UAtvcebhcA =AgjB -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D4FC3928-BDC8-4E0E-9631-E1C23521F711>