Date: Sun, 20 Oct 2013 02:50:18 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r330906 - head/multimedia/vcdpad Message-ID: <20131020005018.GG57066@ithaqua.etoilebsd.net> In-Reply-To: <20131019165702.GA64069@FreeBSD.org> References: <201310191630.r9JGUXZJ049165@svn.freebsd.org> <20131019163648.GA61417@FreeBSD.org> <20131019163946.GF57066@ithaqua.etoilebsd.net> <20131019165702.GA64069@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Cp3Cp8fzgozWLBWL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 19, 2013 at 04:57:02PM +0000, Alexey Dokuchaev wrote: > On Sat, Oct 19, 2013 at 06:39:46PM +0200, Baptiste Daroussin wrote: > > On Sat, Oct 19, 2013 at 04:36:48PM +0000, Alexey Dokuchaev wrote: > > > On Sat, Oct 19, 2013 at 04:30:33PM +0000, Baptiste Daroussin wrote: > > > > New Revision: 330906 > > > > URL: http://svnweb.freebsd.org/changeset/ports/330906 > > > >=20 > > > > [...] > > > > +post-install: > > > > + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/${PORTNAME} > > >=20 > > > How do you know if installed binaries should be post-stripped? Is th= ere > > > automated check involved? What if, for any reason, binary indeed mus= t be > > > installed unstripped? > >=20 > > make stage warns about unstripped binaries if you have DEVELOPERS=3DYES= in your > > make.conf, >=20 > I suppose it should read DEVELOPER, not DEVELOPER_S_, right? yes >=20 > > if you need the binaries unstripped then just do not strip them, those = works > > stripped properly, btw STRIP_CMD respects WITH_DEBUG. >=20 > <pessimistic mode on> > I understand; I was worrying about rare cases when stripping the binary (= not > for debugging) actually renders it unusable in certain circumstances. Do= n't > get me wrong, I also prefer to have installed binaries normally stripped,= but > I vaguely recall there were cases, albeit rarely seen, when upstream actu= ally > intended unstripped installs, for a reason. I just hope that these sorts= of > automatic suggestions would not result in massive commits that would resu= lt > in broken installations. From what I see how easily folks follow portlin= t's > sometimes misguided advice, it could become problem. > </pessimistic mode off> >=20 I second that pessimistic thought :) That is why it is a warning nor an error, any advice on better warning message to avoid this case to happen would be appreciated :) regards, Bapt --Cp3Cp8fzgozWLBWL Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlJjKMoACgkQ8kTtMUmk6Ewv0wCgpSgs/ExOY3gMIJNse10kvDle pxcAn05pEt3wjgaNc9uQtFIx1tV9w3DN =l4cW -----END PGP SIGNATURE----- --Cp3Cp8fzgozWLBWL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131020005018.GG57066>