Date: Sun, 05 Nov 2017 11:56:14 -0700 From: Ian Lepore <ian@freebsd.org> To: Ed Maste <emaste@freebsd.org>, Bryan Drewery <bdrewery@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r325368 - head/sys/kern Message-ID: <1509908174.99235.60.camel@freebsd.org> In-Reply-To: <CAPyFy2D0c6GQvrfE9CAx99Pj%2BF5QU_y%2BB6rpOY3BCPSFNDA5mA@mail.gmail.com> References: <201711031921.vA3JLakQ010001@repo.freebsd.org> <15dc8575-c699-1101-c846-b4fbdef3d1d1@FreeBSD.org> <CAPyFy2D0c6GQvrfE9CAx99Pj%2BF5QU_y%2BB6rpOY3BCPSFNDA5mA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 2017-11-03 at 17:22 -0400, Ed Maste wrote: > "On 3 November 2017 at 16:42, Bryan Drewery <bdrewery@freebsd.org> > wrote: > > > > > > > > > > Differential Revision: D12929 > > Apparently this format closes the review now? I thought we needed a > > full > > URL? > Interesting, Phabricator reports "We found a "Differential Revision" > field with value "12929" in the commit message, and the domain on the > URI matches this install, so we linked this commit to D12929." It > looks like Phabricator was changed to accept only the D##### tag, but > not the "Explain why" text. > I like having the full URL, and would like that to remain the standard. It's very useful when you're perusing svn logs and you can just click on the url to get to the phab material cited in the commit. If people want the convenience of typing the shorter info, could we make the svn commit hooks expand it to an url? -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1509908174.99235.60.camel>