Date: Mon, 17 Jun 2019 12:34:13 +0200 From: Niclas Zeising <zeising@freebsd.org> To: rgrimes@freebsd.org Cc: Benjamin Kaduk <bjkfbsd@gmail.com>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r349133 - head/share/man/man4 Message-ID: <f1f79f31-c2fb-2d54-2bd9-7cea1f995f06@freebsd.org> In-Reply-To: <4e64bb67-7e4b-cd2d-7690-b6be11d78f58@freebsd.org> References: <201906170903.x5H93Wac008131@gndrsh.dnsmgr.net> <4e64bb67-7e4b-cd2d-7690-b6be11d78f58@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-06-17 12:27, Niclas Zeising wrote: > On 2019-06-17 11:03, Rodney W. Grimes wrote: >>> On 2019-06-17 09:56, Benjamin Kaduk wrote: >>>> On Sun, Jun 16, 2019 at 10:42 PM Niclas Zeising <zeising@freebsd.org >>>> <mailto:zeising@freebsd.org>> wrote: >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0 Author: zeising (doc,ports committer) >>>> =C2=A0=C2=A0=C2=A0=C2=A0 Date: Mon Jun 17 05:41:47 2019 >>>> =C2=A0=C2=A0=C2=A0=C2=A0 New Revision: 349133 >>>> =C2=A0=C2=A0=C2=A0=C2=A0 URL: https://svnweb.freebsd.org/changeset/b= ase/349133 >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0 Log: >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ? pci(4): Document PCIOCATTACHED >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ? Document the PCIOCATTACHED ioctl(2)= in the pci(4) manual. >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ? PCIOCATTACHED is used to query if a= driver has attached to a=20 >>>> PCI. >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ? Reviewed by:? bcr, imp >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ? MFC after:? ? 2 weeks >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ? Differential Revision: https://revi= ews.freebsd.org/D20652 >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0 Modified: >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ? head/share/man/man4/pci.4 >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0 Modified: head/share/man/man4/pci.4 >>>> =20 >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=20 >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0 --- head/share/man/man4/pci.4? ?Mon Jun 17 = 03:48:44 2019 >>>> =C2=A0=C2=A0=C2=A0=C2=A0 (r349132) >>>> =C2=A0=C2=A0=C2=A0=C2=A0 +++ head/share/man/man4/pci.4? ?Mon Jun 17 = 05:41:47 2019 >>>> =C2=A0=C2=A0=C2=A0=C2=A0 (r349133) >>>> =C2=A0=C2=A0=C2=A0=C2=A0 @@ -24,7 +24,7 @@ >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?.\" >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?.\" $FreeBSD$ >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?.\" >>>> =C2=A0=C2=A0=C2=A0=C2=A0 -.Dd June 14, 2018 >>>> =C2=A0=C2=A0=C2=A0=C2=A0 +.Dd June 17, 2019 >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?.Dt PCI 4 >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?.Os >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?.Sh NAME >>>> =C2=A0=C2=A0=C2=A0=C2=A0 @@ -333,6 +333,26 @@ The limitations on dat= a width described for >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?reading registers, above, also apply= to writing >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?.Tn PCI >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?configuration registers. >>>> =C2=A0=C2=A0=C2=A0=C2=A0 +.It PCIOCATTACHED >>>> =C2=A0=C2=A0=C2=A0=C2=A0 +This >>>> =C2=A0=C2=A0=C2=A0=C2=A0 +.Xr ioctl 2 >>>> =C2=A0=C2=A0=C2=A0=C2=A0 +allows users to query if a driver is attac= hed to the >>>> =C2=A0=C2=A0=C2=A0=C2=A0 +.Tn PCI >>>> =C2=A0=C2=A0=C2=A0=C2=A0 +specified in the passed-in >>>> >>>> >>>> Is there a missing word like "device" here? >> >> Actally I think the missing word, in both cases, is register, >> unless I am misreading some part of the manual page and >> what a struct pci_io points at.=C2=A0 I guess if the pi_reg is null >> then this would be device.=C2=A0 Either way there is defanity a >> missing word. >=20 > I'll try to fix this.=C2=A0 In the PCIOCWRITE case, perhaps register is= best,=20 > however, inthe PCIOCATTACHED case, device is best, I think. > I'll create a patch and put it for review, I'll get back to you once=20 > it's done. > Regards >=20 Here's the review with my proposed change. Let me know what you think. https://reviews.freebsd.org/D20671 Regards --=20 Niclas Zeising
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f1f79f31-c2fb-2d54-2bd9-7cea1f995f06>