Date: Mon, 01 Apr 2019 20:13:07 +0000 From: bugzilla-noreply@freebsd.org To: toolchain@FreeBSD.org Subject: [Bug 236714] Clang problem with rctl(8) Message-ID: <bug-236714-29464-2yDDAzDQrP@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-236714-29464@https.bugs.freebsd.org/bugzilla/> References: <bug-236714-29464@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236714 --- Comment #5 from Mateusz Guzik <mjg@FreeBSD.org> --- (In reply to Mark Johnston from comment #3) I don't think that's feasible since consumers can pass arbitrary sizes, and some probably pass more than they intended in a bogus manner where they wou= ld not be prepared to sudden zeroing of the area passed. Looks like the bug at hand can be easily taken care of with just resizing t= he var to bool in the userspace tool. While the previous binary remains broken= I don't think it's a big deal since this is current-only. that is: diff --git a/usr.bin/rctl/rctl.c b/usr.bin/rctl/rctl.c index 74073c13207e..f8b5115a4507 100644 --- a/usr.bin/rctl/rctl.c +++ b/usr.bin/rctl/rctl.c @@ -378,8 +378,9 @@ print_rules(char *rules, int hflag, int nflag) static void enosys(void) { - int error, racct_enable; size_t racct_enable_len; + int error; + bool racct_enable; racct_enable_len =3D sizeof(racct_enable); error =3D sysctlbyname("kern.racct.enable", --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-236714-29464-2yDDAzDQrP>