Date: Wed, 2 Sep 2020 13:28:14 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Michael Tuexen <tuexen@fh-muenster.de>, Mateusz Guzik <mjg@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r365071 - in head/sys: net net/altq net/route net80211 netgraph netgraph/atm netgraph/atm/ccatm netgraph/atm/sscfu netgraph/atm/sscop netgraph/atm/uni netgraph/bluetooth/common netgraph... Message-ID: <6124a908-25a5-e023-16da-7963ba229b7f@FreeBSD.org> In-Reply-To: <20200902180626.GA88595@FreeBSD.org> References: <202009012119.081LJERb018106@repo.freebsd.org> <95844C00-D10A-456D-AD29-DF572043074F@fh-muenster.de> <20200902020507.GA38274@FreeBSD.org> <eba32e79-4b90-ecce-7bbb-455f691d4444@FreeBSD.org> <20200902180626.GA88595@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 02/09/2020 13:06, Alexey Dokuchaev wrote: > On Wed, Sep 02, 2020 at 10:18:15AM -0500, Pedro Giffuni wrote: >> On 01/09/2020 21:05, Alexey Dokuchaev wrote: >>> ... >>> This is common sense. I can't count how often I wanted to hack on >>> something in the base/kernel and was turned away by this atrocious >>> excessive whitespace mess. >>> >>> Thank you Mateusz for cleaning this up. >> I honestly don't care much, but spaces do no harm and can make the code >> more readable. Sort of a silent comment, or what you do in written >> language when you start a new paragraph. > Right, but that's the example of appropriate usage of whitespace. I was > talking about *excessive* whitespace, that is, more than two \n's in a row > if we speak of newlines (subject of these commits). But how much space is rather subjective so Michael is right in asking what rule has been violated. No one is asking for the change to be reverted: the damage, if any, is already done. Pedro. > ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6124a908-25a5-e023-16da-7963ba229b7f>