Date: Sun, 10 May 2009 19:49:19 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: swhetzel@gmail.com Cc: ports@freebsd.org, cvs-ports@freebsd.org, QAT@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/net Makefile ports/net/bwi-firmware-kmod Makefile distinfo pkg-descr pkg-plist Message-ID: <20090510.194919.-1350499495.imp@bsdimp.com> In-Reply-To: <790a9fff0905101305l70d7809cl1ca2525729d53daa@mail.gmail.com> References: <200905092141.n49LfomV031060@repoman.freebsd.org> <20090510162002.A2CAA8FC4E@release.ixsystems.com> <790a9fff0905101305l70d7809cl1ca2525729d53daa@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <790a9fff0905101305l70d7809cl1ca2525729d53daa@mail.gmail.co=
m>
Scot Hetzel <swhetzel@gmail.com> writes:
: On Sun, May 10, 2009 at 11:20 AM, <QAT@freebsd.org> wrote:
: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<phase =
6: make install>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
: > add_pkg
: > =3D=3D=3D> =A0Installing for bwi-firmware-kmod-3.130.20
: > =3D=3D=3D> =A0 Generating temporary packing list
: > =3D=3D=3D> =A0Checking if net/bwi-firmware-kmod already installed
: > install -o root -g wheel -m 555 =A0 bwi_v3_ucode.ko /boot/modules
: > kldxref /boot/modules
: > =3D=3D=3D> =A0 Registering installation for bwi-firmware-kmod-3.130=
.20
: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<phase =
7: make package>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
: > =3D=3D=3D> =A0Building package for bwi-firmware-kmod-3.130.20
: > Creating package /tmp/packages/All/bwi-firmware-kmod-3.130.20.tbz
: > Registering depends:.
: > Creating bzip'd tar ball in '/tmp/packages/All/bwi-firmware-kmod-3.=
130.20.tbz'
: > Deleting bwi-firmware-kmod-3.130.20
: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
: >
: > =3D=3D=3D Checking filesystem state
: > list of extra files and directories in / (not present before this p=
ort was installed but present after it was deinstalled)
: > 33067887 =A0 =A0 =A0 =A04 -rw-r--r-- =A0 =A01 root =A0 =A0 =A0 =A0 =
=A0 =A0 wheel =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A088 May 10 16:20 boot/m=
odules/linker.hints
: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
: =
: This shouldn't be flaged as an mtree error. The reason that
: linker.hints was left behind is due to this file is generated by
: kldxref. The port/package runs kldxref during the install of the
: firmware module to update the existing or create a linker.hints file,=
: and when the package is removed, it runs kldxref again to clean up th=
e
: linker.hints file to only contain the modules in /boot/modules. It
: has no way to know if it is safe to remove this file.
: =
: Should Kernel Modules be running kldxref in /boot/modules?
I think so. In general, one needs to run it for optimal performance.
: Should I change the port to have a do-install target that installs th=
e
: bwi firmware kernel module so that it doesn't run kldxref during the
: install?
What do other firmware ports do here?
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090510.194919.-1350499495.imp>