Date: Mon, 26 Feb 2001 09:45:35 +0100 From: Gary Jennejohn <garyj@peedub.muc.de> To: Warner Losh <imp@village.org> Cc: Gary Jennejohn <gj@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/pccard/pccardd util.c Message-ID: <200102260845.f1Q8jZu12976@peedub.muc.de> In-Reply-To: Your message of "Sun, 25 Feb 2001 16:39:01 MST." <200102252339.f1PNd1Y01249@billy-club.village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh writes: > In message <200102251952.f1PJqhe95166@freefall.freebsd.org> Gary Jennejohn wr > ites: > : Use vsnprintf in logmsg() to avoid overflowing the array on the stack. > : The problem was noted with an older model 3Com 3C589 which seems > : to return more than 256 bytes of data. > > The fix is a good one, but the explaination doesn't make sense to be > because CIS tuples are limited to 254 bytes... > > Warner > > well, all I can say is that sticking the card into the slot caused pccardd to core dump. After applying the fix I noticed that the log output contained lots of junk after the ID strings. Apparently this old card didn't stop at 256 bytes or the kernel was reading too much out of the card. --- Gary Jennejohn / garyj@muc.de gj@freebsd.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200102260845.f1Q8jZu12976>