Date: Sun, 20 Jan 2002 20:00:36 +0000 From: Mark Murray <mark@grondar.za> To: "Andrey A. Chernov" <ache@nagual.pp.ru> Cc: markm@FreeBSD.ORG, des@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: Step3, pam_opie snprintf bloat fix for review Message-ID: <200201202000.g0KK0at32884@grimreaper.grondar.org> In-Reply-To: <20020120193121.GA23954@nagual.pp.ru> ; from "Andrey A. Chernov" <ache@nagual.pp.ru> "Sun, 20 Jan 2002 22:31:21 %2B0300." References: <20020120193121.GA23954@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
> Bug: > snprintf is large and slow, increasing program size and slowing it down. > Better way is avoid snprintf when it is not neccessary. > > Fix: > Full functionality of snprintf is not needed below, so it is replaced by > much faster strlcpy. This is fine! Style - please make it 'sizeof(foo)', not 'sizeof foo'. M > --- pam_opie.c.bak Sat Jan 19 21:29:49 2002 > +++ pam_opie.c Sun Jan 20 22:23:18 2002 > @@ -125,7 +125,7 @@ > } > > /* We have to copy the response, because opieverify mucks with it. */ > - snprintf(resp, sizeof resp, "%s", response); > + strlcpy(resp, response, sizeof resp); > > /* > * Opieverify is supposed to return -1 only if an error occurs. > -- > Andrey A. Chernov > http://ache.pp.ru/ > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message -- o Mark Murray \_ FreeBSD Services Limited O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200201202000.g0KK0at32884>