Date: Thu, 18 Dec 2003 03:23:08 -0600 From: "Brandon D. Valentine" <brandon@dvalentine.com> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: prying x11-wm/wmakerconf loose from gnome Message-ID: <20031218092308.GB8284@geekpunk.net> In-Reply-To: <1071733971.59139.34.camel@shumai.marcuscom.com> References: <20031218074613.GA8284@geekpunk.net> <1071733971.59139.34.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 18, 2003 at 02:52:52AM -0500, Joe Marcus Clarke wrote:
> On Thu, 2003-12-18 at 02:46, Brandon D. Valentine wrote:
> > Which of the gnome components contains the "menus" and should be tested
> > against? Should I submit PRs+patches or is there some ports or gnome
> > committer who would prefer to clean these up? They both should be
> > simple to fix.
>
> I agree this is a bug in wmakerconf, but someone will need to determine
> which GNOME component to check for, then modify the HAVE_GNOME test to
> be:
That was exactly what I was asking for advice on.
> .if ${HAVE_GNOME:Mcomponent}!=""
> ...
>
> At that point, the problem should go away. Given that no one has truly
> migrated this port to the new GNOME infrastructure, that "component"
> could be gtkhtml (however, I'm sure gnomelibs would suffice).
I've just been digging around on the web and it looks like gnome2wmaker
is unmaintained, both as a port and in general. The maintainer was set
back to freebsd-ports in early November 2003 by kris. The last time it
was modified before that (save the pkg-comment cleanup) was December
2001. I seriously doubt that it works with gnome2 and I'm certainly not
interested in finding out. I doubt anyone uses this.
In light of that realization, my recommended fix follows my sig in patch
form (removing gnome2wmaker references from the wmakerconf port
altogther). I also recommend that the gnome2wmaker port be moved to the
Attic since it hasn't been ported to gnome2, there is no FreeBSD
maintainer, and there is no upstream maintainer.
HTH,
Brandon D. Valentine
--
brandon@dvalentine.com http://www.geekpunk.net
Pseudo-Random Googlism: leaves is good for boils and swollen hands and
feet
Index: ports/x11-wm/wmakerconf/Makefile
===================================================================
RCS file: /home/ncvs/ports/x11-wm/wmakerconf/Makefile,v
retrieving revision 1.34
diff -u -r1.34 Makefile
--- ports/x11-wm/wmakerconf/Makefile 28 Oct 2003 09:55:31 -0000 1.34
+++ ports/x11-wm/wmakerconf/Makefile 18 Dec 2003 09:08:11 -0000
@@ -7,6 +7,7 @@
PORTNAME= wmakerconf
PORTVERSION= 2.8.1
+PORTREVISION= 1
CATEGORIES= x11-wm
MASTER_SITES= ${MASTER_SITE_NETBSD}
@@ -34,14 +35,6 @@
CONFIGURE_ARGS= --with-wmakerdir="${X11BASE}/share/WindowMaker"
.include <bsd.port.pre.mk>
-
-.if defined(HAVE_GNOME)
-BUILD_DEPENDS+= gnome2wmaker:${PORTSDIR}/x11-wm/gnome2wmaker
-RUN_DEPENDS+= gnome2wmaker:${PORTSDIR}/x11-wm/gnome2wmaker
-PLIST_SUB+= GNOME:=""
-.else
-PLIST_SUB+= GNOME:="@comment "
-.endif
post-configure:
@${PERL} -pi -e 's|%%X11BASE%%|${X11BASE}| ; s|%%LOCALBASE%%|${LOCALBASE}|' \
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031218092308.GB8284>