Date: Tue, 28 Oct 2014 04:08:20 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Kurt Jaeger <pi@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Bruce Evans <brde@optusnet.com.au> Subject: Re: svn commit: r273734 - head/bin/dd Message-ID: <20141028040638.O3114@besplex.bde.org> In-Reply-To: <20141027162034.GN1492@f10.opsec.eu> References: <201410271138.s9RBcHrA002447@svn.freebsd.org> <20141028005225.S2013@besplex.bde.org> <20141027162034.GN1492@f10.opsec.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 27 Oct 2014, Kurt Jaeger wrote: >>> Log: >>> bin/dd: Fix incorrect casting of arguments > [...] >> Both of these work correctly in my version (with a relatively small patch >> and no breakage of other cases). (I actually typed large values as -1 >> and 11111111111111111111111111. -1 means (uintmax_t)-1 although this >> is undocumented and now broken). > > So, given this detailed review, should I revert the change ? Yes. You would have to change half of it just to get it to compile on 32-bit arches. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141028040638.O3114>