Date: Sat, 14 Aug 2004 15:32:20 +0000 (UTC) From: David Malone <dwmalone@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/conf NOTES options src/sys/modules/ip_mroute_mod Makefile src/sys/netinet ip_id.c ip_input.c ip_mroute.c ip_output.c ip_var.h raw_ip.c tcp_syncache.c tcp_usrreq.c src/sys/netinet6 frag6.c in6_pcb.c ... Message-ID: <200408141532.i7EFWKAT043669@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
dwmalone 2004-08-14 15:32:20 UTC FreeBSD src repository Modified files: sys/conf NOTES options sys/modules/ip_mroute_mod Makefile sys/netinet ip_mroute.c ip_input.c ip_output.c raw_ip.c ip_var.h ip_id.c tcp_syncache.c tcp_usrreq.c sys/netinet6 in6_pcb.c frag6.c in6_proto.c ip6_input.c ip6_output.c ip6_id.c ip6_var.h ipsec.c sys/netipsec xform_ipip.c Log: Get rid of the RANDOM_IP_ID option and make it a sysctl. NetBSD have already done this, so I have styled the patch on their work: 1) introduce a ip_newid() static inline function that checks the sysctl and then decides if it should return a sequential or random IP ID. 2) named the sysctl net.inet.ip.random_id 3) IPv6 flow IDs and fragment IDs are now always random. Flow IDs and frag IDs are significantly less common in the IPv6 world (ie. rarely generated per-packet), so there should be smaller performance concerns. The sysctl defaults to 0 (sequential IP IDs). Reviewed by: andre, silby, mlaier, ume Based on: NetBSD MFC after: 2 months Revision Changes Path 1.1259 +1 -8 src/sys/conf/NOTES 1.473 +0 -1 src/sys/conf/options 1.12 +1 -9 src/sys/modules/ip_mroute_mod/Makefile 1.5 +0 -3 src/sys/netinet/ip_id.c 1.282 +5 -3 src/sys/netinet/ip_input.c 1.105 +2 -11 src/sys/netinet/ip_mroute.c 1.224 +1 -6 src/sys/netinet/ip_output.c 1.88 +13 -6 src/sys/netinet/ip_var.h 1.140 +1 -6 src/sys/netinet/raw_ip.c 1.65 +0 -5 src/sys/netinet/tcp_syncache.c 1.106 +1 -6 src/sys/netinet/tcp_usrreq.c 1.24 +0 -5 src/sys/netinet6/frag6.c 1.59 +0 -5 src/sys/netinet6/in6_pcb.c 1.29 +0 -7 src/sys/netinet6/in6_proto.c 1.6 +0 -6 src/sys/netinet6/ip6_id.c 1.75 +0 -4 src/sys/netinet6/ip6_input.c 1.82 +0 -5 src/sys/netinet6/ip6_output.c 1.27 +0 -8 src/sys/netinet6/ip6_var.h 1.36 +1 -6 src/sys/netinet6/ipsec.c 1.9 +1 -6 src/sys/netipsec/xform_ipip.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200408141532.i7EFWKAT043669>