Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Apr 2024 23:05:39 GMT
From:      Christoph Moench-Tegeder <cmt@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: 16543701d7d9 - main - www/firefox-esr: fix linking with libc++18
Message-ID:  <202404182305.43IN5d4s012591@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by cmt:

URL: https://cgit.FreeBSD.org/ports/commit/?id=16543701d7d98630a94e10adeffb8785aa4aa3c9

commit 16543701d7d98630a94e10adeffb8785aa4aa3c9
Author:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
AuthorDate: 2024-04-18 23:04:07 +0000
Commit:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
CommitDate: 2024-04-18 23:05:29 +0000

    www/firefox-esr: fix linking with libc++18
    
    copied from www/firefox
    
    PR:             276746
---
 www/firefox-esr/files/patch-bug1874059 | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/www/firefox-esr/files/patch-bug1874059 b/www/firefox-esr/files/patch-bug1874059
new file mode 100644
index 000000000000..3fa954ef9def
--- /dev/null
+++ b/www/firefox-esr/files/patch-bug1874059
@@ -0,0 +1,25 @@
+commit 56c888446600991803fd92d668349101ad4bf160
+Author: Christoph Moench-Tegeder <cmt@burggraben.net>
+Date:   Tue Feb 6 22:51:27 2024 +0100
+
+    switch to -fvisibility flags
+    
+    this fixes linkage with llvm18 (which does not like the former
+    approach via the #pragma in gcc_hidden.h
+    
+    PR: 276746
+    Submitted by: dim@
+
+diff --git build/moz.configure/toolchain.configure build/moz.configure/toolchain.configure
+index d08b748db250..4696f69153f6 100644
+--- build/moz.configure/toolchain.configure
++++ build/moz.configure/toolchain.configure
+@@ -2186,7 +2186,7 @@ set_define("_LIBCPP_HIDE_FROM_ABI", libcxx_override_visibility.hide_from_abi)
+ @depends(target, build_environment)
+ def visibility_flags(target, env):
+     if target.os != "WINNT":
+-        if target.kernel == "Darwin":
++        if target.kernel == "Darwin" or target.kernel == "FreeBSD":
+             return ("-fvisibility=hidden", "-fvisibility-inlines-hidden")
+         return (
+             "-I%s/system_wrappers" % os.path.join(env.dist),



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202404182305.43IN5d4s012591>