Date: Mon, 11 Mar 2024 11:30:17 +0100 From: Mathieu Arnold <mat@freebsd.org> To: Vladimir Druzenko <vvd@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 79f8f9c8f54b - main - */*: convert Makefile patches to MAKE_ARGS after "Move man pages to share/man" Message-ID: <bp5kdxhfwea63v5gay7x5eooposnvxib2lmqduxbtunxzmb2nq@cagxoxs3nixd> In-Reply-To: <a371bad6-0bee-403a-8d59-957c0c8009be@freebsd.org> References: <202403102258.42AMwcEk042464@gitrepo.freebsd.org> <equjhvaadbyvrm73z7aqlcix2crkzyj4tez5wtbgvxobuifvci@enk3zp4g2g3v> <a371bad6-0bee-403a-8d59-957c0c8009be@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--jealqoxrmhcfovg6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 11, 2024 at 01:08:53PM +0300, Vladimir Druzenko wrote: > 11.03.2024 10:42, Mathieu Arnold =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > On Sun, Mar 10, 2024 at 10:58:38PM +0000, Vladimir Druzenko wrote: > > > The branch main has been updated by vvd: > > >=20 > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D79f8f9c8f54b8de3d324= d30ce9a19649bbe69e69 > > >=20 > > > commit 79f8f9c8f54b8de3d324d30ce9a19649bbe69e69 > > > Author: Vladimir Druzenko <vvd@FreeBSD.org> > > > AuthorDate: 2024-03-10 22:49:41 +0000 > > > Commit: Vladimir Druzenko <vvd@FreeBSD.org> > > > CommitDate: 2024-03-10 22:49:41 +0000 > > >=20 > > > */*: convert Makefile patches to MAKE_ARGS after "Move man pages= to share/man" > > > Replaced patches for Makefiles with "MAKE_ARGS+=3DMANDIR=3D${PRE= FIX}/share/man" > > Why +=3D ? Is the variable defined before in the Makefile ? If it is, t= hen > > you should append to its previous value, if it is not, +=3D will only > > confuse people in the future, wondering why a non existing variable is > > appended to instead of being set. > >=20 > I took other ports as examples, in particular sysutils/lmmon. Looking for examples in the ports tree is not the best idea, people like to be creative and try very hard to not learn how make works so they can continue making creative things. >=20 > Also, AFAIU, "MAKE_ARGS+=3D" allow users add custom options via make.conf= same > as "CFLAGS+=3D". MAKE_ARGS is not a user facing variable, so please, unless it is a master port, and slave ports set MAKE_ARGS, do not use +=3D. --=20 Mathieu Arnold --jealqoxrmhcfovg6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmXu3ThfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb7uzwwAsaqiHNF5uGLjHtZhEk9079fBhHQLK4IEBwgZ4OWMWJiOjm0UnnGJNTsj 8fclVRwZUzYOeNj3uytSyztWULZ3Mjn2KqdU8aQAUGk2dgxM8NMOV3uofCLy5mhg wn0FcfzzJQAzQb7B8VdpoF4WOHgsvmHPaCEtZXriMxmDgJht4Uz5W8QcKqUMkBOq hX55bVJ7w2dCFVt7ZE9NNsSioGup8wZTGO6sQw/UtBCQg6eJl+oSItq8b5pmbkd0 HcbwBZ4Cjp7myni1D7wrddEZlyeI+PwgTKmd7j4jhQP5dpMaqmB6uGLxHNVv56og ExYd2WjiqXOvNIGu7XAKWVCspbTlhQ3+kOXt61uuMMZii4l4Ko0h6thdauL19vUK mBCFmsHjgYYIHW/mGdE/wqJKKL6iBkJOfhBKvxPOlWOhOe0LryVf0MAdsFykXp9X tjSF3shShzAcKSWtUBJBJTw1g+/UVpF2b00uiygjm2qOdtDBtKIGcdBrPVM/WUvK 2nvtrGzf =ZciH -----END PGP SIGNATURE----- --jealqoxrmhcfovg6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bp5kdxhfwea63v5gay7x5eooposnvxib2lmqduxbtunxzmb2nq>