Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 7 Nov 2009 14:26:22 +0700
From:      Eugene Grosbein <eugen@eg.sd.rdtc.ru>
To:        Alexander Best <alexbestms@math.uni-muenster.de>
Cc:        freebsd-hackers@freebsd.org, Jilles Tjoelker <jilles@stack.nl>
Subject:   Re: SIGUNUSED
Message-ID:  <20091107072622.GB14078@rdtc.ru>
In-Reply-To: <permail-2009110702174980e26a0b00004745-a_best01@message-id.uni-muenster.de>
References:  <20091106221150.GA60707@stack.nl> <permail-2009110702174980e26a0b00004745-a_best01@message-id.uni-muenster.de>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Nov 07, 2009 at 03:17:49AM +0100, Alexander Best wrote:

> as a side not:
> our own easyedit does exactly what you said wasn't a good programming style.
> ;) check line 554 of contrib/ee/ee.c:
> 
>         for (counter = 1; counter < 24; counter++)
>                 signal(counter, SIG_IGN);

Easy Editor is contributed software (now lives in contrib/).

Such naive signgal handling had already hurt it in the past,
f.e. plain ignore of SIGTTIN, SIGTTOU without sanity checks for
STDIN_FILENO, STDOUT_FILENO made it CPU hog for 'ee file &'
or 'ee </dev/null' in early versions.

Eugene Grosbein



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091107072622.GB14078>