Date: Thu, 10 Aug 2023 08:53:19 +0200 From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernando.apesteguia@gmail.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 38be56a530a0 - main - textproc/p5-excel2csv: new port had been added (+) Message-ID: <CAGwOe2YTNpBO-aO5dCxKnHzy%2Bg=7D3n7JSQ9HD4vYKfYGuUZrA@mail.gmail.com> In-Reply-To: <202308100620.37A6KIqg017783@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Thu, Aug 10, 2023 at 8:20 AM Alexey Dokuchaev <danfe@freebsd.org> wrote: > The branch main has been updated by danfe: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=38be56a530a004de92b36d35bbd8e85cd9a0fd32 > > commit 38be56a530a004de92b36d35bbd8e85cd9a0fd32 > Author: Alexey Dokuchaev <danfe@FreeBSD.org> > AuthorDate: 2023-08-10 06:19:16 +0000 > Commit: Alexey Dokuchaev <danfe@FreeBSD.org> > CommitDate: 2023-08-10 06:19:16 +0000 > > textproc/p5-excel2csv: new port had been added (+) > > Provides two scripts for converting Microsoft Excel > spreadsheet formats (both XLS and XLSX) to CSV. > This project has seen only 4 commits since 2014 ( https://github.com/xevo/xls2csv/commits/master) It's never had issues (https://github.com/xevo/xls2csv/issues?q=is%3Aissue) or pull request (https://github.com/xevo/xls2csv/pulls?q=is%3Apr) This smells suspicious as in "nobody uses this software". The "parent" project in CPAN has only 3 issues. All of them unresolved for the last 7, 9 and 12 years ( https://rt.cpan.org/Public/Dist/Display.html?Name=xls2csv). One of them is marked as critical. Is this really something we want to have in the tree? > > PR: 254499 > Submitted by: Henrik Rosenke > --- > textproc/Makefile | 1 + > textproc/p5-excel2csv/Makefile | 28 ++++++++++++++++++++++++++++ > textproc/p5-excel2csv/distinfo | 3 +++ > textproc/p5-excel2csv/pkg-descr | 6 ++++++ > textproc/p5-excel2csv/pkg-plist | 4 ++++ > 5 files changed, 42 insertions(+) > > diff --git a/textproc/Makefile b/textproc/Makefile > index edaeabaa11f9..77e2a36a5153 100644 > --- a/textproc/Makefile > +++ b/textproc/Makefile > @@ -1192,6 +1192,7 @@ > SUBDIR += p5-ack > SUBDIR += p5-dTemplate > SUBDIR += p5-docx2txt > + SUBDIR += p5-excel2csv > SUBDIR += p5-libsoldout > SUBDIR += p5-libxml > SUBDIR += p5-pod2pdf > diff --git a/textproc/p5-excel2csv/Makefile > b/textproc/p5-excel2csv/Makefile > new file mode 100644 > index 000000000000..74d252723474 > --- /dev/null > +++ b/textproc/p5-excel2csv/Makefile > @@ -0,0 +1,28 @@ > +PORTNAME= excel2csv > +PORTVERSION= 1.07 > +CATEGORIES= textproc perl5 > +PKGNAMEPREFIX= p5- > + > +MAINTAINER= rosenke@dssgmbh.de > +COMMENT= Convert Microsoft Excel spreadsheets to CSV format > +WWW= https://github.com/xevo/xls2csv > + > +LICENSE= GPLv2 > + > +RUN_DEPENDS= p5-Locale-libintl>0:devel/p5-Locale-libintl \ > + > p5-Spreadsheet-ParseExcel>0:textproc/p5-Spreadsheet-ParseExcel \ > + p5-Spreadsheet-XLSX>0:textproc/p5-Spreadsheet-XLSX \ > + p5-Text-CSV_XS>0:textproc/p5-Text-CSV_XS \ > + p5-Text-Iconv>0:converters/p5-Text-Iconv \ > + p5-Unicode-Map>0:converters/p5-Unicode-Map > + > +USES= perl5 > +USE_PERL5= configure > +USE_GITHUB= yes > +GH_ACCOUNT= xevo > +GH_PROJECT= xls2csv > +GH_TAGNAME= 49386af > + > +NO_ARCH= yes > + > +.include <bsd.port.mk> > diff --git a/textproc/p5-excel2csv/distinfo > b/textproc/p5-excel2csv/distinfo > new file mode 100644 > index 000000000000..e1b95d608961 > --- /dev/null > +++ b/textproc/p5-excel2csv/distinfo > @@ -0,0 +1,3 @@ > +TIMESTAMP = 1624458591 > +SHA256 (xevo-xls2csv-1.07-49386af_GH0.tar.gz) = > 32444583fce3cda5314df691d675dd4fa148d7da840053d4fa1a9a4ec15ca92b > +SIZE (xevo-xls2csv-1.07-49386af_GH0.tar.gz) = 15454 > diff --git a/textproc/p5-excel2csv/pkg-descr > b/textproc/p5-excel2csv/pkg-descr > new file mode 100644 > index 000000000000..6d46b5bbc313 > --- /dev/null > +++ b/textproc/p5-excel2csv/pkg-descr > @@ -0,0 +1,6 @@ > +excel2csv provides two scripts for converting Microsoft Excel spreadsheet > +formats XLS and XLSX to CSV. Improvements compared to the CPAN version: > + > + - Supports XLSX files > + - Handles character encodings much better > + - The options make more sense > diff --git a/textproc/p5-excel2csv/pkg-plist > b/textproc/p5-excel2csv/pkg-plist > new file mode 100644 > index 000000000000..b8518ed2dade > --- /dev/null > +++ b/textproc/p5-excel2csv/pkg-plist > @@ -0,0 +1,4 @@ > +bin/excel2csv > +bin/xls2csv > +%%PERL5_MAN1%%/excel2csv.1.gz > +%%PERL5_MAN1%%/xls2csv.1.gz > [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Aug 10, 2023 at 8:20 AM Alexey Dokuchaev <<a href="mailto:danfe@freebsd.org">danfe@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by danfe:<br> <br> URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=38be56a530a004de92b36d35bbd8e85cd9a0fd32" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=38be56a530a004de92b36d35bbd8e85cd9a0fd32</a><br>; <br> commit 38be56a530a004de92b36d35bbd8e85cd9a0fd32<br> Author: Alexey Dokuchaev <danfe@FreeBSD.org><br> AuthorDate: 2023-08-10 06:19:16 +0000<br> Commit: Alexey Dokuchaev <danfe@FreeBSD.org><br> CommitDate: 2023-08-10 06:19:16 +0000<br> <br> textproc/p5-excel2csv: new port had been added (+)<br> <br> Provides two scripts for converting Microsoft Excel<br> spreadsheet formats (both XLS and XLSX) to CSV.<br></blockquote><div><br></div><div>This project has seen only 4 commits since 2014 (<a href="https://github.com/xevo/xls2csv/commits/master">https://github.com/xevo/xls2csv/commits/master</a>)</div><div>It's never had issues (<a href="https://github.com/xevo/xls2csv/issues?q=is%3Aissue">https://github.com/xevo/xls2csv/issues?q=is%3Aissue</a>) or pull request (<a href="https://github.com/xevo/xls2csv/pulls?q=is%3Apr">https://github.com/xevo/xls2csv/pulls?q=is%3Apr</a>)</div><div>This smells suspicious as in "nobody uses this software".<br></div><div>The "parent" project in CPAN has only 3 issues. All of them unresolved for the last 7, 9 and 12 years (<a href="https://rt.cpan.org/Public/Dist/Display.html?Name=xls2csv">https://rt.cpan.org/Public/Dist/Display.html?Name=xls2csv</a>).</div><div>One of them is marked as critical.</div><div><br></div><div>Is this really something we want to have in the tree?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> PR: 254499<br> Submitted by: Henrik Rosenke<br> ---<br> textproc/Makefile | 1 +<br> textproc/p5-excel2csv/Makefile | 28 ++++++++++++++++++++++++++++<br> textproc/p5-excel2csv/distinfo | 3 +++<br> textproc/p5-excel2csv/pkg-descr | 6 ++++++<br> textproc/p5-excel2csv/pkg-plist | 4 ++++<br> 5 files changed, 42 insertions(+)<br> <br> diff --git a/textproc/Makefile b/textproc/Makefile<br> index edaeabaa11f9..77e2a36a5153 100644<br> --- a/textproc/Makefile<br> +++ b/textproc/Makefile<br> @@ -1192,6 +1192,7 @@<br> SUBDIR += p5-ack<br> SUBDIR += p5-dTemplate<br> SUBDIR += p5-docx2txt<br> + SUBDIR += p5-excel2csv<br> SUBDIR += p5-libsoldout<br> SUBDIR += p5-libxml<br> SUBDIR += p5-pod2pdf<br> diff --git a/textproc/p5-excel2csv/Makefile b/textproc/p5-excel2csv/Makefile<br> new file mode 100644<br> index 000000000000..74d252723474<br> --- /dev/null<br> +++ b/textproc/p5-excel2csv/Makefile<br> @@ -0,0 +1,28 @@<br> +PORTNAME= excel2csv<br> +PORTVERSION= 1.07<br> +CATEGORIES= textproc perl5<br> +PKGNAMEPREFIX= p5-<br> +<br> +MAINTAINER= <a href="mailto:rosenke@dssgmbh.de" target="_blank">rosenke@dssgmbh.de</a><br> +COMMENT= Convert Microsoft Excel spreadsheets to CSV format<br> +WWW= <a href="https://github.com/xevo/xls2csv" rel="noreferrer" target="_blank">https://github.com/xevo/xls2csv</a><br>; +<br> +LICENSE= GPLv2<br> +<br> +RUN_DEPENDS= p5-Locale-libintl>0:devel/p5-Locale-libintl \<br> + p5-Spreadsheet-ParseExcel>0:textproc/p5-Spreadsheet-ParseExcel \<br> + p5-Spreadsheet-XLSX>0:textproc/p5-Spreadsheet-XLSX \<br> + p5-Text-CSV_XS>0:textproc/p5-Text-CSV_XS \<br> + p5-Text-Iconv>0:converters/p5-Text-Iconv \<br> + p5-Unicode-Map>0:converters/p5-Unicode-Map<br> +<br> +USES= perl5<br> +USE_PERL5= configure<br> +USE_GITHUB= yes<br> +GH_ACCOUNT= xevo<br> +GH_PROJECT= xls2csv<br> +GH_TAGNAME= 49386af<br> +<br> +NO_ARCH= yes<br> +<br> +.include <<a href="http://bsd.port.mk" rel="noreferrer" target="_blank">bsd.port.mk</a>><br> diff --git a/textproc/p5-excel2csv/distinfo b/textproc/p5-excel2csv/distinfo<br> new file mode 100644<br> index 000000000000..e1b95d608961<br> --- /dev/null<br> +++ b/textproc/p5-excel2csv/distinfo<br> @@ -0,0 +1,3 @@<br> +TIMESTAMP = 1624458591<br> +SHA256 (xevo-xls2csv-1.07-49386af_GH0.tar.gz) = 32444583fce3cda5314df691d675dd4fa148d7da840053d4fa1a9a4ec15ca92b<br> +SIZE (xevo-xls2csv-1.07-49386af_GH0.tar.gz) = 15454<br> diff --git a/textproc/p5-excel2csv/pkg-descr b/textproc/p5-excel2csv/pkg-descr<br> new file mode 100644<br> index 000000000000..6d46b5bbc313<br> --- /dev/null<br> +++ b/textproc/p5-excel2csv/pkg-descr<br> @@ -0,0 +1,6 @@<br> +excel2csv provides two scripts for converting Microsoft Excel spreadsheet<br> +formats XLS and XLSX to CSV. Improvements compared to the CPAN version:<br> +<br> + - Supports XLSX files<br> + - Handles character encodings much better<br> + - The options make more sense<br> diff --git a/textproc/p5-excel2csv/pkg-plist b/textproc/p5-excel2csv/pkg-plist<br> new file mode 100644<br> index 000000000000..b8518ed2dade<br> --- /dev/null<br> +++ b/textproc/p5-excel2csv/pkg-plist<br> @@ -0,0 +1,4 @@<br> +bin/excel2csv<br> +bin/xls2csv<br> +%%PERL5_MAN1%%/excel2csv.1.gz<br> +%%PERL5_MAN1%%/xls2csv.1.gz<br> </blockquote></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2YTNpBO-aO5dCxKnHzy%2Bg=7D3n7JSQ9HD4vYKfYGuUZrA>