Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 Aug 2023 08:53:19 +0200
From:      =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernando.apesteguia@gmail.com>
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,  dev-commits-ports-main@freebsd.org
Subject:   Re: git: 38be56a530a0 - main - textproc/p5-excel2csv: new port had been added (+)
Message-ID:  <CAGwOe2YTNpBO-aO5dCxKnHzy%2Bg=7D3n7JSQ9HD4vYKfYGuUZrA@mail.gmail.com>
In-Reply-To: <202308100620.37A6KIqg017783@gitrepo.freebsd.org>
References:  <202308100620.37A6KIqg017783@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000e3c0ab06028c0d3e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 10, 2023 at 8:20=E2=80=AFAM Alexey Dokuchaev <danfe@freebsd.org=
> wrote:

> The branch main has been updated by danfe:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=3D38be56a530a004de92b36d35bbd8e=
85cd9a0fd32
>
> commit 38be56a530a004de92b36d35bbd8e85cd9a0fd32
> Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
> AuthorDate: 2023-08-10 06:19:16 +0000
> Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
> CommitDate: 2023-08-10 06:19:16 +0000
>
>     textproc/p5-excel2csv: new port had been added (+)
>
>     Provides two scripts for converting Microsoft Excel
>     spreadsheet formats (both XLS and XLSX) to CSV.
>

This project has seen only 4 commits since 2014 (
https://github.com/xevo/xls2csv/commits/master)
It's never had issues (https://github.com/xevo/xls2csv/issues?q=3Dis%3Aissu=
e)
or pull request (https://github.com/xevo/xls2csv/pulls?q=3Dis%3Apr)
This smells suspicious as in "nobody uses this software".
The "parent" project in CPAN has only 3 issues. All of them unresolved for
the last 7, 9 and 12 years (
https://rt.cpan.org/Public/Dist/Display.html?Name=3Dxls2csv).
One of them is marked as critical.

Is this really something we want to have in the tree?


>
>     PR:             254499
>     Submitted by:   Henrik Rosenke
> ---
>  textproc/Makefile               |  1 +
>  textproc/p5-excel2csv/Makefile  | 28 ++++++++++++++++++++++++++++
>  textproc/p5-excel2csv/distinfo  |  3 +++
>  textproc/p5-excel2csv/pkg-descr |  6 ++++++
>  textproc/p5-excel2csv/pkg-plist |  4 ++++
>  5 files changed, 42 insertions(+)
>
> diff --git a/textproc/Makefile b/textproc/Makefile
> index edaeabaa11f9..77e2a36a5153 100644
> --- a/textproc/Makefile
> +++ b/textproc/Makefile
> @@ -1192,6 +1192,7 @@
>      SUBDIR +=3D p5-ack
>      SUBDIR +=3D p5-dTemplate
>      SUBDIR +=3D p5-docx2txt
> +    SUBDIR +=3D p5-excel2csv
>      SUBDIR +=3D p5-libsoldout
>      SUBDIR +=3D p5-libxml
>      SUBDIR +=3D p5-pod2pdf
> diff --git a/textproc/p5-excel2csv/Makefile
> b/textproc/p5-excel2csv/Makefile
> new file mode 100644
> index 000000000000..74d252723474
> --- /dev/null
> +++ b/textproc/p5-excel2csv/Makefile
> @@ -0,0 +1,28 @@
> +PORTNAME=3D      excel2csv
> +PORTVERSION=3D   1.07
> +CATEGORIES=3D    textproc perl5
> +PKGNAMEPREFIX=3D p5-
> +
> +MAINTAINER=3D    rosenke@dssgmbh.de
> +COMMENT=3D       Convert Microsoft Excel spreadsheets to CSV format
> +WWW=3D           https://github.com/xevo/xls2csv
> +
> +LICENSE=3D       GPLv2
> +
> +RUN_DEPENDS=3D   p5-Locale-libintl>0:devel/p5-Locale-libintl \
> +
>  p5-Spreadsheet-ParseExcel>0:textproc/p5-Spreadsheet-ParseExcel \
> +               p5-Spreadsheet-XLSX>0:textproc/p5-Spreadsheet-XLSX \
> +               p5-Text-CSV_XS>0:textproc/p5-Text-CSV_XS \
> +               p5-Text-Iconv>0:converters/p5-Text-Iconv \
> +               p5-Unicode-Map>0:converters/p5-Unicode-Map
> +
> +USES=3D          perl5
> +USE_PERL5=3D     configure
> +USE_GITHUB=3D    yes
> +GH_ACCOUNT=3D    xevo
> +GH_PROJECT=3D    xls2csv
> +GH_TAGNAME=3D    49386af
> +
> +NO_ARCH=3D       yes
> +
> +.include <bsd.port.mk>
> diff --git a/textproc/p5-excel2csv/distinfo
> b/textproc/p5-excel2csv/distinfo
> new file mode 100644
> index 000000000000..e1b95d608961
> --- /dev/null
> +++ b/textproc/p5-excel2csv/distinfo
> @@ -0,0 +1,3 @@
> +TIMESTAMP =3D 1624458591
> +SHA256 (xevo-xls2csv-1.07-49386af_GH0.tar.gz) =3D
> 32444583fce3cda5314df691d675dd4fa148d7da840053d4fa1a9a4ec15ca92b
> +SIZE (xevo-xls2csv-1.07-49386af_GH0.tar.gz) =3D 15454
> diff --git a/textproc/p5-excel2csv/pkg-descr
> b/textproc/p5-excel2csv/pkg-descr
> new file mode 100644
> index 000000000000..6d46b5bbc313
> --- /dev/null
> +++ b/textproc/p5-excel2csv/pkg-descr
> @@ -0,0 +1,6 @@
> +excel2csv provides two scripts for converting Microsoft Excel spreadshee=
t
> +formats XLS and XLSX to CSV.  Improvements compared to the CPAN version:
> +
> +  - Supports XLSX files
> +  - Handles character encodings much better
> +  - The options make more sense
> diff --git a/textproc/p5-excel2csv/pkg-plist
> b/textproc/p5-excel2csv/pkg-plist
> new file mode 100644
> index 000000000000..b8518ed2dade
> --- /dev/null
> +++ b/textproc/p5-excel2csv/pkg-plist
> @@ -0,0 +1,4 @@
> +bin/excel2csv
> +bin/xls2csv
> +%%PERL5_MAN1%%/excel2csv.1.gz
> +%%PERL5_MAN1%%/xls2csv.1.gz
>

--000000000000e3c0ab06028c0d3e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Thu, Aug 10, 2023 at 8:20=E2=80=AF=
AM Alexey Dokuchaev &lt;<a href=3D"mailto:danfe@freebsd.org">danfe@freebsd.=
org</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"marg=
in:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1e=
x">The branch main has been updated by danfe:<br>
<br>
URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D38be56a530a004d=
e92b36d35bbd8e85cd9a0fd32" rel=3D"noreferrer" target=3D"_blank">https://cgi=
t.FreeBSD.org/ports/commit/?id=3D38be56a530a004de92b36d35bbd8e85cd9a0fd32</=
a><br>
<br>
commit 38be56a530a004de92b36d35bbd8e85cd9a0fd32<br>
Author:=C2=A0 =C2=A0 =C2=A0Alexey Dokuchaev &lt;danfe@FreeBSD.org&gt;<br>
AuthorDate: 2023-08-10 06:19:16 +0000<br>
Commit:=C2=A0 =C2=A0 =C2=A0Alexey Dokuchaev &lt;danfe@FreeBSD.org&gt;<br>
CommitDate: 2023-08-10 06:19:16 +0000<br>
<br>
=C2=A0 =C2=A0 textproc/p5-excel2csv: new port had been added (+)<br>
<br>
=C2=A0 =C2=A0 Provides two scripts for converting Microsoft Excel<br>
=C2=A0 =C2=A0 spreadsheet formats (both XLS and XLSX) to CSV.<br></blockquo=
te><div><br></div><div>This project has seen only 4 commits since 2014 (<a =
href=3D"https://github.com/xevo/xls2csv/commits/master">https://github.com/=
xevo/xls2csv/commits/master</a>)</div><div>It&#39;s never had issues (<a hr=
ef=3D"https://github.com/xevo/xls2csv/issues?q=3Dis%3Aissue">https://github=
.com/xevo/xls2csv/issues?q=3Dis%3Aissue</a>) or pull request (<a href=3D"ht=
tps://github.com/xevo/xls2csv/pulls?q=3Dis%3Apr">https://github.com/xevo/xl=
s2csv/pulls?q=3Dis%3Apr</a>)</div><div>This smells suspicious as in &quot;n=
obody uses this software&quot;.<br></div><div>The &quot;parent&quot; projec=
t in CPAN has only 3 issues. All of them unresolved for the last 7, 9 and 1=
2 years (<a href=3D"https://rt.cpan.org/Public/Dist/Display.html?Name=3Dxls=
2csv">https://rt.cpan.org/Public/Dist/Display.html?Name=3Dxls2csv</a>).</di=
v><div>One of them is marked as critical.</div><div><br></div><div>Is this =
really something we want to have in the tree?<br></div><div>=C2=A0</div><bl=
ockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-lef=
t:1px solid rgb(204,204,204);padding-left:1ex">
<br>
=C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0254499<br>
=C2=A0 =C2=A0 Submitted by:=C2=A0 =C2=A0Henrik Rosenke<br>
---<br>
=C2=A0textproc/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0|=C2=A0 1 +<br>
=C2=A0textproc/p5-excel2csv/Makefile=C2=A0 | 28 +++++++++++++++++++++++++++=
+<br>
=C2=A0textproc/p5-excel2csv/distinfo=C2=A0 |=C2=A0 3 +++<br>
=C2=A0textproc/p5-excel2csv/pkg-descr |=C2=A0 6 ++++++<br>
=C2=A0textproc/p5-excel2csv/pkg-plist |=C2=A0 4 ++++<br>
=C2=A05 files changed, 42 insertions(+)<br>
<br>
diff --git a/textproc/Makefile b/textproc/Makefile<br>
index edaeabaa11f9..77e2a36a5153 100644<br>
--- a/textproc/Makefile<br>
+++ b/textproc/Makefile<br>
@@ -1192,6 +1192,7 @@<br>
=C2=A0 =C2=A0 =C2=A0SUBDIR +=3D p5-ack<br>
=C2=A0 =C2=A0 =C2=A0SUBDIR +=3D p5-dTemplate<br>
=C2=A0 =C2=A0 =C2=A0SUBDIR +=3D p5-docx2txt<br>
+=C2=A0 =C2=A0 SUBDIR +=3D p5-excel2csv<br>
=C2=A0 =C2=A0 =C2=A0SUBDIR +=3D p5-libsoldout<br>
=C2=A0 =C2=A0 =C2=A0SUBDIR +=3D p5-libxml<br>
=C2=A0 =C2=A0 =C2=A0SUBDIR +=3D p5-pod2pdf<br>
diff --git a/textproc/p5-excel2csv/Makefile b/textproc/p5-excel2csv/Makefil=
e<br>
new file mode 100644<br>
index 000000000000..74d252723474<br>
--- /dev/null<br>
+++ b/textproc/p5-excel2csv/Makefile<br>
@@ -0,0 +1,28 @@<br>
+PORTNAME=3D=C2=A0 =C2=A0 =C2=A0 excel2csv<br>
+PORTVERSION=3D=C2=A0 =C2=A01.07<br>
+CATEGORIES=3D=C2=A0 =C2=A0 textproc perl5<br>
+PKGNAMEPREFIX=3D p5-<br>
+<br>
+MAINTAINER=3D=C2=A0 =C2=A0 <a href=3D"mailto:rosenke@dssgmbh.de" target=3D=
"_blank">rosenke@dssgmbh.de</a><br>
+COMMENT=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0Convert Microsoft Excel spreadsheets =
to CSV format<br>
+WWW=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"https://github.c=
om/xevo/xls2csv" rel=3D"noreferrer" target=3D"_blank">https://github.com/xe=
vo/xls2csv</a><br>
+<br>
+LICENSE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0GPLv2<br>
+<br>
+RUN_DEPENDS=3D=C2=A0 =C2=A0p5-Locale-libintl&gt;0:devel/p5-Locale-libintl =
\<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0p5-Spreadsheet-Pars=
eExcel&gt;0:textproc/p5-Spreadsheet-ParseExcel \<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0p5-Spreadsheet-XLSX=
&gt;0:textproc/p5-Spreadsheet-XLSX \<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0p5-Text-CSV_XS&gt;0=
:textproc/p5-Text-CSV_XS \<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0p5-Text-Iconv&gt;0:=
converters/p5-Text-Iconv \<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0p5-Unicode-Map&gt;0=
:converters/p5-Unicode-Map<br>
+<br>
+USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 perl5<br>
+USE_PERL5=3D=C2=A0 =C2=A0 =C2=A0configure<br>
+USE_GITHUB=3D=C2=A0 =C2=A0 yes<br>
+GH_ACCOUNT=3D=C2=A0 =C2=A0 xevo<br>
+GH_PROJECT=3D=C2=A0 =C2=A0 xls2csv<br>
+GH_TAGNAME=3D=C2=A0 =C2=A0 49386af<br>
+<br>
+NO_ARCH=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0yes<br>
+<br>
+.include &lt;<a href=3D"http://bsd.port.mk" rel=3D"noreferrer" target=3D"_=
blank">bsd.port.mk</a>&gt;<br>
diff --git a/textproc/p5-excel2csv/distinfo b/textproc/p5-excel2csv/distinf=
o<br>
new file mode 100644<br>
index 000000000000..e1b95d608961<br>
--- /dev/null<br>
+++ b/textproc/p5-excel2csv/distinfo<br>
@@ -0,0 +1,3 @@<br>
+TIMESTAMP =3D 1624458591<br>
+SHA256 (xevo-xls2csv-1.07-49386af_GH0.tar.gz) =3D 32444583fce3cda5314df691=
d675dd4fa148d7da840053d4fa1a9a4ec15ca92b<br>
+SIZE (xevo-xls2csv-1.07-49386af_GH0.tar.gz) =3D 15454<br>
diff --git a/textproc/p5-excel2csv/pkg-descr b/textproc/p5-excel2csv/pkg-de=
scr<br>
new file mode 100644<br>
index 000000000000..6d46b5bbc313<br>
--- /dev/null<br>
+++ b/textproc/p5-excel2csv/pkg-descr<br>
@@ -0,0 +1,6 @@<br>
+excel2csv provides two scripts for converting Microsoft Excel spreadsheet<=
br>
+formats XLS and XLSX to CSV.=C2=A0 Improvements compared to the CPAN versi=
on:<br>
+<br>
+=C2=A0 - Supports XLSX files<br>
+=C2=A0 - Handles character encodings much better<br>
+=C2=A0 - The options make more sense<br>
diff --git a/textproc/p5-excel2csv/pkg-plist b/textproc/p5-excel2csv/pkg-pl=
ist<br>
new file mode 100644<br>
index 000000000000..b8518ed2dade<br>
--- /dev/null<br>
+++ b/textproc/p5-excel2csv/pkg-plist<br>
@@ -0,0 +1,4 @@<br>
+bin/excel2csv<br>
+bin/xls2csv<br>
+%%PERL5_MAN1%%/excel2csv.1.gz<br>
+%%PERL5_MAN1%%/xls2csv.1.gz<br>
</blockquote></div></div>

--000000000000e3c0ab06028c0d3e--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2YTNpBO-aO5dCxKnHzy%2Bg=7D3n7JSQ9HD4vYKfYGuUZrA>