Date: Fri, 17 May 2019 11:31:55 -0500 From: Jason Bacon <bacon4000@gmail.com> To: Piotr Kubaj <pkubaj@anongoth.pl>, Dima Panov <fluffy@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r501874 - head/sysutils/plasma5-libksysguard Message-ID: <e909a89c-4522-0ac8-3119-8d33dc10ef60@gmail.com> In-Reply-To: <20190517160132.GA80452@ThinkPad-X200.g.anongoth.pl> References: <201905171459.x4HExatn090007@repo.freebsd.org> <20190517160132.GA80452@ThinkPad-X200.g.anongoth.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
Would it be too difficult to fix qt5-webengine where it doesn't currently build? I've been adding logic in support of specific architectures to some of my ports, but I think this sort of thing should be kept to a minimum in favor of fixing the root issue wherever possible. Less clutter and greater benefit. On 2019-05-17 11:01, Piotr Kubaj wrote: > This commit will make this port to be skipped on all architectures > where qt5-webengine is not available. > > Could you enable WEBENGINE option only on those architectures where > qt5-webengine actually builds? > > On 19-05-17 14:59:36, Dima Panov wrote: >> Author: fluffy >> Date: Fri May 17 14:59:35 2019 >> New Revision: 501874 >> URL: https://svnweb.freebsd.org/changeset/ports/501874 >> >> Log: >> - Enable QtWebEngine plugin use in libksysguard components >> >> Modified: >> head/sysutils/plasma5-libksysguard/Makefile >> >> Modified: head/sysutils/plasma5-libksysguard/Makefile >> ============================================================================== >> >> --- head/sysutils/plasma5-libksysguard/Makefile Fri May 17 >> 14:45:19 2019 (r501873) >> +++ head/sysutils/plasma5-libksysguard/Makefile Fri May 17 >> 14:59:35 2019 (r501874) >> @@ -2,6 +2,7 @@ >> >> PORTNAME= libksysguard >> DISTVERSION= ${KDE_PLASMA_VERSION} >> +DISTERSION= 1 >> CATEGORIES= sysutils kde kde-plasma >> >> MAINTAINER= kde@FreeBSD.org >> @@ -13,5 +14,12 @@ USE_KDE= auth codecs completion config >> configwidgets c >> plasma-framework service widgetsaddons windowsystem >> USE_QT= core dbus gui network script webkit widgets x11extras >> xml \ >> buildtools_build qmake_build >> + >> +OPTIONS_DEFINE= WEBENGINE >> +OPTIONS_DEFAULT= WEBENGINE >> + >> +WEBENGINE_USE= QT=webengine >> +WEBENGINE_DESC= HTML-based GUI ksysguard library based on >> Qt5WebEngine >> +WORKSPACE_CMAKE_BOOL_OFF= >> CMAKE_DISABLE_FIND_PACKAGE_Qt5WebEngineWidgets >> >> .include <bsd.port.mk> >> >> >> -- >> This message has been scanned for viruses and >> dangerous content by MailScanner, and is >> believed to be clean. >> -- Earth is a beta site.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e909a89c-4522-0ac8-3119-8d33dc10ef60>