Date: Sat, 28 Oct 2000 01:31:23 +1100 (EST) From: Darren Reed <darrenr@reed.wattle.id.au> To: ru@FreeBSD.org (Ruslan Ermilov) Cc: net@FreeBSD.org Subject: Re: [CFR] IPFILTER patch Message-ID: <200010271431.BAA19966@avalon.reed.wattle.id.au> In-Reply-To: <20001027170933.A36523@sunbay.com> from Ruslan Ermilov at "Oct 27, 0 05:09:33 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
In some email I received from Ruslan Ermilov, sie wrote: > Hi! > > As we discussed yesterday, here are the patches to IPFILTER > that are needed for my upcoming "byte-swapping elimination" > patch. Sorry, it took a bit more than an hour... Hmm, there are some problems with this. In some cases, off is being put into an int (should always be a u_short) but of more concern is that you're treating fin_off as both a byte address (you shift it left three times) and as the eight byte offset it actually is in the packet. Cheers, Darren To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200010271431.BAA19966>