Date: Mon, 13 Jan 2003 09:26:10 +0100 From: Pawel Jakub Dawidek <nick@garage.freebsd.pl> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sbin/ipfw ipfw.8 ipfw2.c Message-ID: <20030113082610.GH9430@garage.freebsd.pl> In-Reply-To: <200301130819.h0D8JsJc001902@apollo.backplane.com> References: <200301120331.h0C3VA2H040455@repoman.freebsd.org> <20030113075934.GE9430@garage.freebsd.pl> <200301130807.h0D87urr001783@apollo.backplane.com> <20030113081749.GF9430@garage.freebsd.pl> <200301130819.h0D8JsJc001902@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Jan 13, 2003 at 12:19:54AM -0800, Matthew Dillon wrote: +> You are looking at the old ipfw code. Look at the sysctl's in +> ip_fw2.c instead. Either way it is not really relevant to my +> commit, I didn't make any changes to the IPFW kernel code, only +> to the userland program. Sorry. But IMHO in ip_fw2.c this sysctl works bad as well. CTLFLAG_SECURE prevent from changing sysctl when securelevel >= 0 and this prevention should be only when >= 3. But sysctl definition in ip_fw.c is bad, right? If yes, maybe some PR should be sent? -- Pawel Jakub Dawidek UNIX Systems Administrator http://garage.freebsd.pl Am I Evil? Yes, I Am. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iQCVAwUBPiJ4Ij/PhmMH/Mf1AQEkbgP/fXfn6kVjk6pxLe61xBorDy0wkf1mLi1m iEk/PYYrsvzcVs0UCocnL5AC+WWmuB67et9/xeLhOpmBqtDGMo300cmVWn6l5WfK L7myMBv/mS6JeP1P9MigcZctZSFXBpxYyE/g3gkfXoH5V9d+w99qgDT0CiVdsJq2 WpvlrK+Ney0= =wjvO -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030113082610.GH9430>