Date: Fri, 17 Sep 2010 21:43:25 +0000 From: Bernhard Froehlich <decke@FreeBSD.org> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: freebsd-gecko@freebsd.org, Beat Gaetzi <beat@freebsd.org> Subject: Re: Fwd: IcedTea6 Mozilla plugin with OpenJDK6 Message-ID: <071d10ee11e2cc21de2172038d989e2a@bluelife.at> In-Reply-To: <201009170021.08900.jkim@FreeBSD.org> References: <201009091828.12400.jkim@FreeBSD.org> <4C89E15C.7020608@FreeBSD.org> <201009170021.08900.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 17 Sep 2010 00:21:05 -0400, Jung-uk Kim <jkim@FreeBSD.org>
wrote:
> On Friday 10 September 2010 03:42 am, Beat Gaetzi wrote:
>> On 10.09.2010 00:28, Jung-uk Kim wrote:
>> > While I was porting a Mozilla plugin, I found something
>> > disturbing:
>> >
>> > %pkg-config --modversion mozilla-plugin
>> > 1.9.2.8
>> > %pkg-config --cflags mozilla-plugin
>> > -DXP_UNIX -I/usr/local/include/libxul/stable
>> > %ls -dl /usr/local/include/libxul/stable/
>> > ls: /usr/local/include/libxul/stable/: No such file or directory
>> > %pkg_info -W /usr/local/libdata/pkgconfig/mozilla-plugin.pc
>> > /usr/local/libdata/pkgconfig/mozilla-plugin.pc was installed by
>> > package libxul-1.9.2.8 %pkg-config --cflags libxul
>> > -fshort-wchar -I/usr/local/include/libxul
>> > -I/usr/local/include/nspr %ls -dl /usr/local/include/libxul/
>> > drwxr-xr-x 11 root wheel 56832 Aug 9 16:21
>> > /usr/local/include/libxul/
>> >
>> > As you can see, --cflags returns a nonexistent directory for
>> > mozilla-plugin package. It returns the correct directory for
>> > libxul, though. As a workaround, I had to do this:
>> >
>> > # XXX Need to fix in ports.
>> > CFLAGS+= ${PLUGIN_CFLAGS:C/\/libxul\/stable/\/libxul/}
>> >
>> > Can anyone explain what's going on here?
>>
>> The stable and unstable include directories no longer exists with
>> libxul 1.9.2. I don't know why the stable directory is still listed
>> in the mozilla-plugin.pc file. Should we add this substitution to
>> the libxul port?
>
> Please see the attached patch. It seems this is the only file that
> references include/libxul/stable now.
Thanks for the patch! I committed it a few minutes ago.
--
Bernhard Froehlich
http://www.bluelife.at/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?071d10ee11e2cc21de2172038d989e2a>