Date: Sat, 4 Dec 1999 14:02:05 -0800 (PST) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: adam@algroup.co.uk (Adam Laurie) Cc: nate@mt.sri.com (Nate Williams), jhb@FreeBSD.ORG (John Baldwin), freebsd-security@FreeBSD.ORG Subject: Re: rc.firewall revisited Message-ID: <199912042202.OAA85441@gndrsh.dnsmgr.net> In-Reply-To: <3849746D.9B9F18E8@algroup.co.uk> from Adam Laurie at "Dec 4, 1999 08:07:09 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
... Didn't even read the rest, already wasted too much of my time on
this thread ... It has been saved for reading when cdiff is in hand ...
> > Provide a context or uni diff to -currents /etc/rc.firewall and I'll give you
> > a ``review'', and a possible ``commit''.
>
> Fine. Can I also include the other changes I mentioned (moving IP
> addresses into variables, which will also require some additions to
> rc.conf, and a whole new section for a standalone pc)?
You can submit anything you want, but remember I am going to ``review'' it,
which means you may get a lot of things back you'll need to go work on :-).
Like a request for a handbook section to explain all the new knobs you
added, and man page updates, etc, etc... People think Bruce is a nit pick,
well, Just ask Sheldon about my ``reviews'' some time. The sh(1) man
page update process was 20 some odd iterations and 3 to 4 weeks of wall
clock time before it got the ``Reviewed by:'' stamp from me. The bde sio(4)
and fastintr(9) driver code going into FreeBSD 1.0 was something like 100
iterations, a 50% code change, and a man month of time on both mine and
Bruces part.
--
Rod Grimes - KD7CAX @ CN85sl - (RWG25) rgrimes@gndrsh.dnsmgr.net
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-security" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199912042202.OAA85441>