Date: Fri, 02 Nov 2018 04:05:46 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: Mark Linimon <linimon@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r483758 - head/devel/libpru Message-ID: <5zxg-fab9-wny@FreeBSD.org> In-Reply-To: <201811020135.wA21ZqbL037253@repo.freebsd.org> (Mark Linimon's message of "Fri, 2 Nov 2018 01:35:52 %2B0000 (UTC)") References: <201811020135.wA21ZqbL037253@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Mark Linimon <linimon@FreeBSD.org> writes:
> -.include <bsd.port.mk>
> +.include <bsd.port.pre.mk>
> +
> +post-patch:
> +.if ${ARCH:Mmips*} || ${ARCH:Mpowerpc*} || ${ARCH} == sparc64
> + ${REINPLACE_CMD} -e 's/ -Weverything//' ${WRKSRC}/CMakeLists.txt
> +.endif
> +
> +.include <bsd.port.post.mk>
ARCH is defined in bsd.port.options.mk. For pre/post better check
CHOSEN_COMPILER_TYPE (needs USES=compiler) instead of each arch
individually. Some may switch to Clang in future, rendering the
conditional obsolete.
-Weverything also breaks build on Tier1 archs for users who for whatever
reason prefer GCC. As this port is not maintained you can as well drop
-Weverything unconditionally because using it together with -Werror
isn't a good idea (for Clang upgrades).
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5zxg-fab9-wny>