Date: Tue, 16 Jan 2007 15:55:35 -0500 From: John Baldwin <jhb@freebsd.org> To: Kip Macy <kmacy@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 112916 for review Message-ID: <200701161555.36296.jhb@freebsd.org> In-Reply-To: <200701150005.l0F05DZt019533@repoman.freebsd.org> References: <200701150005.l0F05DZt019533@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 14 January 2007 19:05, Kip Macy wrote: > http://perforce.freebsd.org/chv.cgi?CH=112916 > > Change 112916 by kmacy@kmacy_serendipity:sam_wifi on 2007/01/15 00:04:17 > > ensure that the ic lock is acquired before the driver softc lock > enroll them in the proper order in WITNESS > > Affected files ... > > .. //depot/projects/wifi/sys/kern/subr_witness.c#20 edit > > Differences ... > > ==== //depot/projects/wifi/sys/kern/subr_witness.c#20 (text+ko) ==== > > @@ -361,6 +361,18 @@ > { "nfsd_mtx", &lock_class_mtx_sleep }, > { "so_snd", &lock_class_mtx_sleep }, > { NULL, NULL }, > + > + /* > + * IEEE 802.11 > + */ > + { "802.11 com lock", &lock_class_mtx_sleep}, > + { NULL, NULL }, > + /* > + * Network drivers > + */ > + { "network driver", &lock_class_mtx_sleep}, > + { NULL, NULL }, > + This doesn't encode any orders. You probably need to drop the NULL, NULL after "802.11 com lock". Basically, the order list is a list of lists, with each list terminated by a NULL, NULL, and the list of lists terminated by a double NULL, NULL. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200701161555.36296.jhb>