Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 13 Apr 2003 00:11:23 +1000
From:      Tim Robbins <tjr@FreeBSD.ORG>
To:        Johan Karlsson <johan@freebsd.org>
Cc:        sos@freebsd.org
Subject:   Re: makeing atacontrol WARNS=2 clean.
Message-ID:  <20030413001123.A4544@dilbert.robbins.dropbear.id.au>
In-Reply-To: <20030412135916.GA11752@numeri.campus.luth.se>; from johan@freebsd.org on Sat, Apr 12, 2003 at 03:59:16PM %2B0200
References:  <20030412135916.GA11752@numeri.campus.luth.se>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Apr 12, 2003 at 03:59:16PM +0200, Johan Karlsson wrote:

> Hi Søren and others.
> 
> I intend to commit this patch to make atacontrol WARNS=2 clean.
> 
> I hope it's ok with you.
[...]

>  .include <bsd.prog.mk>
> Index: atacontrol/atacontrol.c
> ===================================================================
> RCS file: /home/ncvs/src/sbin/atacontrol/atacontrol.c,v
> retrieving revision 1.20
> diff -u -r1.20 atacontrol.c
> --- atacontrol/atacontrol.c	22 Mar 2003 12:18:20 -0000	1.20
> +++ atacontrol/atacontrol.c	24 Mar 2003 13:22:07 -0000
> @@ -30,6 +30,7 @@
>  
>  #include <sys/types.h>
>  #include <sys/ata.h>
> +#include <sys/stdint.h>
>  
>  #include <err.h>
>  #include <errno.h>

It would be better to use <stdint.h> here, even though it is exactly the same
as <sys/stdint.h>.


Tim



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030413001123.A4544>