Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 04 Nov 2019 09:09:58 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 240788] [NEW PORT] sysutils/ansible-sysrc: Ansible module to set sysvars in rc.conf
Message-ID:  <bug-240788-7788-yXYxfm4A0m@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-240788-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-240788-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240788

--- Comment #23 from Raphael Kubo da Costa <rakuco@FreeBSD.org> ---
Comment on attachment 208827
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D208827
port diff

Removing the call to ansible-config finally made the port build fine here. =
The
difference could be that I'm using poudriere-devel, but other than that I'm
just invoking `poudriere testport -p default -j 13amd64 -i -o
sysutils/ansible-sysrc' and have DEVELOPER_MODE=3Dyes in make.conf.

As for the patch, one thing that can still be improved:

+ANSIBLE_MOD=3D   ${PREFIX}/share/${PYTHON_PKGNAMEPREFIX}ansible/plugins/mo=
dules
+
+PLIST_FILES=3D   $$(${ECHO_CMD} ${ANSIBLE_MOD} | ${SED} -e
's|${PREFIX}/||')/sysrc

The echo+sed combination is unnecessary, remember you're setting ANSIBLE_MOD
yourself. My suggestion is to do something like

  ANSIBLE_MOD_REL=3D share/${PYTHON_PKGNAMEPREFIX}ansible/plugins/modules
  PLIST_FILES=3D ${ANSIBLE_MOD_REL}/sysrc
  do-install:
    [...]
    ${INSTALL_SCRIPT} ${WRKSRC}/library/sysrc
${STAGEDIR}${PREFIX}/${ANSIBLE_MOD_REL}/sysrc

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-240788-7788-yXYxfm4A0m>