Date: Fri, 30 Aug 2024 10:25:53 +0300 From: Gleb Popov <arrowd@freebsd.org> To: Nicola Vitale <nivit@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 35db13a201c4 - main - audio/pulseaudio-module-sndio: Fix build with poudriere Message-ID: <CALH631=%2BWXQQ5Bg1GWiOXcfoNWkkc7OhzVy=E4VaNWFWEA41=w@mail.gmail.com> In-Reply-To: <202408292017.47TKHMcD004669@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Thu, Aug 29, 2024 at 11:17 PM Nicola Vitale <nivit@freebsd.org> wrote: > > The branch main has been updated by nivit: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=35db13a201c4e9314accbf051083265e45dee758 > > commit 35db13a201c4e9314accbf051083265e45dee758 > Author: Nicola Vitale <nivit@FreeBSD.org> > AuthorDate: 2024-08-29 20:07:37 +0000 > Commit: Nicola Vitale <nivit@FreeBSD.org> > CommitDate: 2024-08-29 20:07:37 +0000 > > audio/pulseaudio-module-sndio: Fix build with poudriere > > As pointed out by arrowd@, the previous patch doesn't work in poudriere > "because the pkg-config executable isn't there at the time the variable > value is evaluated". So put the variables in the standard position in > the Makefile and fix the regular expression of sed(1). It still doesn't work, unfortunately - the order in which variables are defined doesn't matter here. The root of the problem is that pkg-config is called during the fetch stage, but it gets checked for as a dependency and installed during the later build stage. It works if you already have pkg-config installed, but in the Poudriere case we always start from an empty system. I think this should be solved by extracting the variable containing the Pulseaudio version into a separate file Makefile.version, which is then included into both ports. I did a similar thing here: https://github.com/freebsd/freebsd-ports/commit/fc94b4e3dde63313c7f915630c496fe3d50e19a0home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALH631=%2BWXQQ5Bg1GWiOXcfoNWkkc7OhzVy=E4VaNWFWEA41=w>