Date: Thu, 30 Apr 2026 19:30:06 +0100 From: Oliver Pinter <oliver.pntr@gmail.com> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com>, =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= <des@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 566cc005812b - main - safe_set treat ':' and '#' differently Message-ID: <CAPjTQNFrg8yf3ze5eh%2BAgMmG%2B0fUOjtBHj1yg6NT__StAtMhDA@mail.gmail.com> In-Reply-To: <6875.1777333471@kaos.jnpr.net> References: <69e8f964.39869.24418b55@gitrepo.freebsd.org> <86jyts1xzr.fsf@ltc.des.dev> <15177.1777314263@kaos.jnpr.net> <86bjf41chq.fsf@ltc.des.dev> <24831.1777314998@kaos.jnpr.net> <A23772E7-6D51-46E6-BD9C-515D70C16BEA@gmail.com> <6875.1777333471@kaos.jnpr.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tuesday, April 28, 2026, Simon J. Gerraty <sjg@juniper.net> wrote: > Enji Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > > > > Using `:` as a comment marker seems a bit esoteric (at best) — > > Using : in the manner I described is extremely useful for being able to > debug complex systems written in sh. There is no useful alternative. > > The change is harmless, and allows safe_set to be re-used in > other contexts. > > I see zero benefit to reverting it. Could you please add some unit test for the supported use cases to avoid future confusions? [-- Attachment #2 --] <br><br>On Tuesday, April 28, 2026, Simon J. Gerraty <<a href="mailto:sjg@juniper.net">sjg@juniper.net</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Enji Cooper (yaneurabeya) <<a href="mailto:yaneurabeya@gmail.com">yaneurabeya@gmail.com</a>> wrote:<br> > <br> > Using `:` as a comment marker seems a bit esoteric (at best) —<br> <br> Using : in the manner I described is extremely useful for being able to<br> debug complex systems written in sh. There is no useful alternative.<br> <br> The change is harmless, and allows safe_set to be re-used in<br> other contexts.<br> <br> I see zero benefit to reverting it.</blockquote><div><br></div><div>Could you please add some unit test for the supported use cases to avoid future confusions?</div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPjTQNFrg8yf3ze5eh%2BAgMmG%2B0fUOjtBHj1yg6NT__StAtMhDA>